Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoSuchElementException when using wrapping.strategy: SINGLE_EDGE with edge labels #1079

Open
Eddykasp opened this issue Oct 9, 2024 · 2 comments
Labels
alg-layered Affects the ELK Layered algorithm. bug Erroneous behaviour.

Comments

@Eddykasp
Copy link
Contributor

Eddykasp commented Oct 9, 2024

When the layered wrapping strategy attemps to make a cut on an edge that also has a label, a NoSuchElementException occurs in the LabelDummySwitcher.

Uncommenting the edge in the linked example leads to the error.

Example in elklive

Expected behavior
Wrapping should work properly with edges that have labels too.

@Eddykasp Eddykasp added bug Erroneous behaviour. alg-layered Affects the ELK Layered algorithm. labels Oct 9, 2024
@soerendomroes
Copy link
Contributor

If I remember this correctly, the issue should be that the method that executes the cuts only works for "normal" edge dummies and not label dummies.

@Eddykasp
Copy link
Contributor Author

Eddykasp commented Nov 8, 2024

The solution to this problem is to check whether the cut indeces have been placed at label dummy nodes. This is currently not checked and leads to problems during later processors.
This branch fixes this issue for the MSDCutIndexHeuristic. This needs to be done for all heuristics for single and multi edge strategies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alg-layered Affects the ELK Layered algorithm. bug Erroneous behaviour.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants