Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if unnecessary copies could be avoided in DDS callbacks #193

Open
JEnoch opened this issue Jul 19, 2024 · 0 comments
Open

Check if unnecessary copies could be avoided in DDS callbacks #193

JEnoch opened this issue Jul 19, 2024 · 0 comments

Comments

@JEnoch
Copy link
Member

JEnoch commented Jul 19, 2024

Describe the feature

The callback passed at DDS Reader creation is expecting a &DDSRawSample as argument:

F: Fn(&DDSRawSample) + std::marker::Send + 'static,

Thus forcing a copy when converting to ZBytes on call to put():

if let Err(e) = publisher.put(sample.payload_as_slice()).wait() {

If possible, giving ownership of DDSRawSample to the callback would avoid copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant