Toggle line comment

[damianozucconi]

Hi,

I've already asked on the Mailing List something about function "Toggle line comment" not available on Javascript editor with WWD.
With latest WWD version 1.1.0 the function seems to be not available:

Java editor context menu:

Javascript editor context menu:

The key shortcut CTRL + SHIFT + C has no effect

Is this a problem/error on my installation or this function is effectively not available ?

Many thanks

[mickaelistria]

This works for me. Can you please check which version of org.eclipse.tm4e.languageconfiguration is used by your IDE?

[damianozucconi]

TextMate Core 0.5.5.202305171341 org.eclipse.tm4e.feature.feature.group Eclipse TM4E
TextMate Language Pack 0.2.0.202305071450 org.eclipse.tm4e.language_pack.feature.feature.group Eclipse TM4E

[damianozucconi]

Updated today (but still no toggle line comment on javascript for me):

*** Plug-in Registry:
org.eclipse.tm4e.languageconfiguration (0.5.5.202305171341) "TextMate support in Eclipse IDE - Language Configurations" [Active]

*** User Preferences:
/instance/org.eclipse.tm4e.languageconfiguration/org.eclipse.tm4e.languageConfigurations=[{"path":"language-configurations/css/language-configuration.json","pluginId":"org.eclipse.wildwebdeveloper","contentTypeId":"org.eclipse.wildwebdeveloper.css","onEnterEnabled":true,"bracketAutoClosingEnabled":false,"matchingPairsEnabled":true},{"path":"javascript/javascript-language-configuration.json","pluginId":"org.eclipse.tm4e.language_pack","contentTypeId":"lng.javascriptreact","onEnterEnabled":false,"bracketAutoClosingEnabled":true,"matchingPairsEnabled":true},{"path":"language-configurations/javascript/javascript-language-configuration.json","pluginId":"org.eclipse.wildwebdeveloper","contentTypeId":"org.eclipse.wildwebdeveloper.js","onEnterEnabled":false,"bracketAutoClosingEnabled":false,"matchingPairsEnabled":true},{"path":"javascript/javascript-language-configuration.json","pluginId":"org.eclipse.tm4e.language_pack","contentTypeId":"lng.javascript","onEnterEnabled":false,"bracketAutoClosingEnabled":true,"matchingPairsEnabled":true}]
@org.eclipse.tm4e.languageconfiguration=0.5.5.202305171341

*** Current Install Configuration:

Id: org.eclipse.tm4e.languageconfiguration, Version: 0.5.5.202305171341, Location: reference:file:plugins/org.eclipse.tm4e.languageconfiguration_0.5.5.202305171341.jar

[vrubezhny]

That works for me - Ctrl-Shift-C successfully toggles a line comment in JavaScript and TypeScript.

@damianozucconi Do you have any tm4e related StackTraces in your <Workspace>/.metadata/.log (and/or back_X.log files in the same directory. If any, please share by opening an issue at https://github.com/eclipse/tm4e/issues

[damianozucconi]

In .log file I've found this error:
!ENTRY org.eclipse.tm4e.languageconfiguration 4 0 2023-05-26 11:10:52.507 !MESSAGE /language-configurations/javascript/javascript-language-configuration.json !STACK 0 java.io.FileNotFoundException: /language-configurations/javascript/javascript-language-configuration.json at org.eclipse.osgi.storage.url.bundleentry.Handler.findBundleEntry(Handler.java:55) at org.eclipse.osgi.storage.url.BundleResourceHandler.openConnection(BundleResourceHandler.java:182) at java.base/java.net.URL.openConnection(URL.java:1094) at org.eclipse.core.internal.boot.PlatformURLConnection.connect(PlatformURLConnection.java:115) at org.eclipse.core.internal.boot.PlatformURLConnection.connect(PlatformURLConnection.java:96) at org.eclipse.core.internal.boot.PlatformURLConnection.getInputStream(PlatformURLConnection.java:231) at java.base/java.net.URL.openStream(URL.java:1161) at org.eclipse.tm4e.registry.TMResource.getInputStream(TMResource.java:77) at org.eclipse.tm4e.languageconfiguration.internal.registry.LanguageConfigurationDefinition.getLanguageConfiguration(LanguageConfigurationDefinition.java:137) at org.eclipse.tm4e.languageconfiguration.internal.registry.AbstractLanguageConfigurationRegistryManager.getLanguageConfigurationFor(AbstractLanguageConfigurationRegistryManager.java:61) at org.eclipse.tm4e.languageconfiguration.internal.HasLanguageConfigurationPropertyTester.test(HasLanguageConfigurationPropertyTester.java:59) at org.eclipse.core.internal.expressions.Property.test(Property.java:65) at org.eclipse.core.expressions.TestExpression.evaluate(TestExpression.java:107) at org.eclipse.core.expressions.CompositeExpression.evaluateAnd(CompositeExpression.java:54) at org.eclipse.core.expressions.WithExpression.evaluate(WithExpression.java:84) at org.eclipse.core.expressions.ReferenceExpression.evaluate(ReferenceExpression.java:72) at org.eclipse.ui.internal.services.EvaluationReference.evaluate(EvaluationReference.java:79) at org.eclipse.ui.internal.services.EvaluationReference.evaluate(EvaluationReference.java:109) at org.eclipse.ui.internal.services.EvaluationReference.changed(EvaluationReference.java:103) at org.eclipse.e4.core.internal.contexts.TrackableComputationExt.update(TrackableComputationExt.java:105) at org.eclipse.e4.core.internal.contexts.EclipseContext.processScheduled(EclipseContext.java:358) at org.eclipse.e4.core.internal.contexts.EclipseContext.set(EclipseContext.java:374) at org.eclipse.e4.core.internal.contexts.EclipseContext.activate(EclipseContext.java:661) at org.eclipse.e4.core.internal.contexts.EclipseContext.activateBranch(EclipseContext.java:670) at org.eclipse.e4.ui.internal.workbench.PartActivationHistory.activate(PartActivationHistory.java:58) at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:764) at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:683) at org.eclipse.e4.ui.internal.workbench.swt.AbstractPartRenderer.activate(AbstractPartRenderer.java:97) at org.eclipse.e4.ui.workbench.renderers.swt.ContributedPartRenderer.lambda$0(ContributedPartRenderer.java:63) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4256) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1066) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1090) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1075) at org.eclipse.swt.widgets.Shell.setActiveControl(Shell.java:1530) at org.eclipse.swt.widgets.Shell.WM_MOUSEACTIVATE(Shell.java:2441) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4787) at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:340) at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1478) at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2284) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java:91) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4844) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java:91) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4844) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java:91) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4844) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java:91) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4844) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java:91) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4844) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java:91) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4844) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java:91) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4844) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java:91) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4844) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java:91) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4844) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java:91) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4844) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method) at org.eclipse.swt.widgets.Tree.callWindowProc(Tree.java:1484) at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:6043) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.CallWindowProc(Native Method) at org.eclipse.swt.widgets.Tree.callWindowProc(Tree.java:1576) at org.eclipse.swt.widgets.Control.windowProc(Control.java:4844) at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:6142) at org.eclipse.swt.widgets.Display.windowProc(Display.java:5022) at org.eclipse.swt.internal.win32.OS.PeekMessage(Native Method) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3637) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1155) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1046) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:155) at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:643) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:550) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:171) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:136) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:402) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:596) at org.eclipse.equinox.launcher.Main.run(Main.java:1467)
It seems that
/language-configurations/javascript/javascript-language-configuration.json
is missing in my installation. How can I try to fix/restore it ?

[vrubezhny]

@damianozucconi You have to update WidWebDeveloper. This problem looks like the already solved one - we've switched to use *.jsonc language configuration files for JavaScript/TypeScript sometime ago, while looking at your stacktrace I see javascript-language-configuration.json referenced. So, it looks like an old WWD version is used.

[damianozucconi]

In Eclipse installation details seems that my installation is updated:

TextMate Core	0.5.6.202305251940
TextMate Language Pack	0.2.0.202305071450
Wild Web Developer HTML, CSS, JSON, Yaml, JavaScript, TypeScript, Node tools	1.1.1.202305232103
Wild Web Developer XML tools	1.1.0.202304242122

but in .log:

!ENTRY org.eclipse.tm4e.languageconfiguration 4 0 2023-05-29 09:27:24.604
!MESSAGE /language-configurations/javascript/javascript-language-configuration.json
!STACK 0
java.io.FileNotFoundException: /language-configurations/javascript/javascript-language-configuration.json 

searching the /language-configurations/javascript path in my Eclipse folder, the path is resolved as:
\plugins\org.eclipse.wildwebdeveloper_1.0.7.202305232103\language-configurations\javascript
So it seems that it's looking in an old installation path...
Also tried to re-install Eclipse from base package but no way to resolve this issue...

[vrubezhny]

@damianozucconi Just to make sure... Could you please post a listing of your <eclipse installation directory>/plugins/org.eclipse.wildwebdeveloper_* plugins? I expect that you have more than one version installed.

Do you have m2e-core installed? If yes, could you please update it from the latest release - https://download.eclipse.org/technology/m2e/releases/latest/ (2.3.0) and try again. The m2e-core of versions older than 2.3.0 aren't API compatible to WWD 1.1.1.

Also you can try Restoring to Defaults in TM4E Language Configurations preference page, which, for JavaScripts, normally should
look like:

[vrubezhny]

And as a "last try", if everything is installed correctly, there is only one o.e.wildwebdeveloper plugin version in your eclipse/plugins folder and no m2e-core or at lease v.2.3.0 is installed, but still json and not jsonc appears to be the extension for the JavaScript/TypeScript language configuration files...

As some metadata/plugn information may be cached by eclipse for performance reasons, try running your eclipse with -clean argument - this should clean the cached configurations so the cache will be re-generated.

[damianozucconi]

My WWD plugin directories

M2E is installed. It should be already latest version:

  M2E - Complete Development Kit	2.3.0.20230523-2106
  M2E - Maven Integration for Eclipse	2.3.0.20230523-2033
  M2E - PDE Integration	2.2.100.20230523-1752
  M2E - POM Editor using LemMinX language server (includes Incubating components)	2.0.4.20230520-0934
  M2E - SLF4J over Logback Logging	2.1.2.20230523-2106

Restored TM4E default configuration, but I see no changes:

Restarted Eclipse with -clean option but no change...

Anyway, the "toggle line comment" CTRL + SHIFT + C option works for me with other languages (such as XML or SQL)
I've also tryed to edit the .jsonc file removing comments and saving it as .json into the same path org.eclipse.wildwebdeveloper_1.0.7.202305232103. In this case the option appears in source context menù but doesn't work

[vrubezhny]

Well. That's odd... The language configurations for JavaScript are changed from *.json to *.jsonc a long before WWD v.1.0.3 and it looks like continue persisting in cache or you have yet another o.w.wildwebdeveloper plugin (v. <0.6.1) in your eclipse/plugins directory which is taken by o.e.tm4e.languageconfigurations to read these configs from...

I don't recommend you changing the contents of Language Configurations as well as other data as it may break the plugins functionality.

I'd suggest try:

• removing the org.eclipse.wildwebdeveloper_1.0.3.202303081618 directory (as well as any other version found less than v.1.0.7 - it may be either stored in directory or as a jar archive in plugins directory),
• restoring the initial contents of o.e.wildwebdeveloper_1.0.7.xxx if you modified it
• and restarting with-clearPersistedState

Sorry, I probably have confused with the correct clean option - probably should be:

-clearPersistedState (E4) - Removes any cached state of the user interface and reloads the model

[damianozucconi]

I followed your suggestions (also Eclipse clearPersistedState) but no change in TextMate language configuration settings.
Removed old WWD folders and also old JARs.
I also removed the embedded NodeJS by reinstalling it as a standalone binary.
Today I updated WWD 1.1.2 and removed the old org.eclipse.wildwebdeveloper_1.0.7.xxx folder because it was replaced by the newer org.eclipse.wildwebdeveloper_1.0.8.202305292001
My question is: where is the TM4E language configuration loaded from?

In the JSX case the path seems to be updated and correct...

[vrubezhny]

@damianozucconi Could you, please, create a new workspace (completely new, not reusing any old workspace directories) and import one (or a few, if required) projects you work on or create a new project and see what happens:

• try working with JavaScript files and toggling line comments
• Look if JavaScript Language Configuration has changed in TM4E Language Configurations preference page?

[damianozucconi]

Starting with a new workspace finally solved the issue !
My old workspace was 10 (or more) years old, updated by many versions of Eclipse.
I've also re-installed Eclipse from scratch because after many changes and tests the XML support was lost...
Now I've to import all projects from old workspace but I hope it is an investment for the future.
Thank you very much for your help, also because the problem was not caused by WWD

[vrubezhny]

@damianozucconi I suspect that the problematic language configurations are cached somewhere in your workspace's .metadata/.plugins/org.eclipse.core.resource/ but I have no clear and safe way on how to clean it to suggest.

So, re-creating workspace from scratch, imho, is the best way to get rid of this cached stuff and save your work done in the old workspace at least while you're configuring your new workspace.

Glad to see your problem solved.