You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The names of these methods are misleading.
When placed side by side, createCredentialsOptions appears to be method that create CredentialsOptions and getCredentialsOptions appears to just return CredentialsOptions.
However, they actually create PublicKeyCredentialCreationOptions and PublicKeyCredentialGetOptions, respectively.
Since introducing a new module vertx-auth-webauthn4j is a good chance to make a breaking change from vertx-auth-webauthn, I think these methods should be renamed to createPublicKeyCredentialCreationOptions and createPublicKeyCredentialGetOptions.
The text was updated successfully, but these errors were encountered:
vertx-auth/vertx-auth-webauthn4j/src/main/java/io/vertx/ext/auth/webauthn4j/WebAuthn4J.java
Line 64 in f2fe958
vertx-auth/vertx-auth-webauthn4j/src/main/java/io/vertx/ext/auth/webauthn4j/WebAuthn4J.java
Line 76 in f2fe958
The names of these methods are misleading.
When placed side by side,
createCredentialsOptions
appears to be method that createCredentialsOptions
andgetCredentialsOptions
appears to just returnCredentialsOptions
.However, they actually create
PublicKeyCredentialCreationOptions
andPublicKeyCredentialGetOptions
, respectively.Since introducing a new module
vertx-auth-webauthn4j
is a good chance to make a breaking change fromvertx-auth-webauthn
, I think these methods should be renamed tocreatePublicKeyCredentialCreationOptions
andcreatePublicKeyCredentialGetOptions
.The text was updated successfully, but these errors were encountered: