Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: proposed TRG 7.09 for repository deprecation #1045

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Oct 2, 2024

Description

Proposed a TRG for product deprecation including a process and criteria to close #1037

I didn't create a draft as I don't want to create two PRs following non-merged process within this PR.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@tom-rm-meyer-ISST
Copy link
Contributor Author

@eclipse-tractusx/automotive-tractusx-committers Please check

@evegufy evegufy requested a review from a team October 2, 2024 09:13
@matbmoser
Copy link
Contributor

@tom-rm-meyer-ISST should not the project leads deprecate the product? Not the committer it self. I would say the committer needs to inform the project leads

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tom-rm-meyer-ISST thank you for proposing the TRG! Looks really good so far, just some comments.
If possible, I'd like to discuss the process in Committers Meeting this Friday (Oct. 11, 2024).

docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
@tom-rm-meyer-ISST
Copy link
Contributor Author

Incorporated requested changes. Clearlydefined seems to be down.

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late re-review!

docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
docs/release/trg-7/trg-7-09.md Outdated Show resolved Hide resolved
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tom-rm-meyer-ISST

@tom-rm-meyer-ISST
Copy link
Contributor Author

@arnoweiss & @matbmoser please check. I think three reviews would be sufficient

@tom-rm-meyer-ISST tom-rm-meyer-ISST changed the title docs: proposed TRG 7.09 docs: proposed TRG 7.09 for repository deprecation Nov 14, 2024
Copy link
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matbmoser
Copy link
Contributor

Wonderful job @tom-rm-meyer-ISST !

@tom-rm-meyer-ISST
Copy link
Contributor Author

@evegufy do you want to cross-check again? Else I would merge latest eob and write a short mail to the dev mailing list.

I won't be available in todays meeting (that's why I'm writing here :))

@evegufy
Copy link
Contributor

evegufy commented Nov 15, 2024

@tom-rm-meyer-ISST all fine from my side. Yes, please inform over the mailing list once merged, thank you :)

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit cbf612b into main Nov 15, 2024
5 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the docs/1037-trg-7-09-product-deprecation branch November 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Propose TRG for product deprecation
4 participants