Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code scanning alert - disallow dangling underscores in identifiers #406

Open
1 task
egekorkan opened this issue Nov 25, 2022 · 1 comment
Open
1 task

Fix code scanning alert - disallow dangling underscores in identifiers #406

egekorkan opened this issue Nov 25, 2022 · 1 comment
Assignees
@fatadel

Comments

@egekorkan
Copy link
Member

Tracking issue for:

I am not sure if this is a real issue or not. Removing the underscore breaks visualization of children
@egekorkan
Copy link
Member Author

I did a fix, probably a dirty one, by renaming _children to privChildren. That is copied over code but I think the _ is used for a "private" attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fatadel fatadel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fatadel @egekorkan