-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth2 example does not work #873
Comments
Error message comes from |
As mentioned above the source of this issue is coming from the |
@danielpeintner @egekorkan @sebastiankb should |
Mhh, good question. I can see use-cases where an HTTP server might be allowing multiple security schemes but I do not know the consequences w.r.t. implementation 🤔 |
I do not have a very good answer but an answer at least:
Summary of my thoughts would be to classify this feature as a nice-to-have but the original issue should be fixed. |
Linking my comment to a previous issue #204. Basically this is another reason why we should support multiple security schemes -> different web things might need different security mechanisms. |
Note that this means that the server is able to expose Things with different security requirements. For example, it is possibile to now have a Thing with `nosec` security scheme and one with `basic` security scheme. As a side effect, the OAuth example now works as explained in eclipse-thingweb#873. Fix eclipse-thingweb#204 eclipse-thingweb#873
* feat(http-binding): add supports for multiple security schemes Note that this means that the server is able to expose Things with different security requirements. For example, it is possibile to now have a Thing with `nosec` security scheme and one with `basic` security scheme. As a side effect, the OAuth example now works as explained in #873. Fix #204 #873 * refactor(binding-http/http-server): rename supportedSecuritySchemes * refactor(binding-http/routes/common): rename utility functions * fix(binding-http/routers): handle cors for no-thing paths * fixup! fix(binding-http/routers): handle cors for no-thing paths
fixed by #1070 |
With @egekorkan I have discussed this issue. I tried to run the example oauth code provided. I have not changed any code and simply followed the instruction mentioned in the Readme.md file but nothing was getting printed when I ran the consumer.js file. Then I enabled the debug level so that the exposer.js can print the log and I saw the following error:
'node-wot:cli:cli:error WoT-Servient cannot start. Error: Servient does not support thing security schemes. Current scheme supported: OAuth secCandidate'
https://github.com/eclipse/thingweb.node-wot/tree/master/examples/security/oauth
The text was updated successfully, but these errors were encountered: