Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Tests with Parcel Watcher #14257

Open
tsmaeder opened this issue Oct 7, 2024 · 3 comments
Open

Failing Tests with Parcel Watcher #14257

tsmaeder opened this issue Oct 7, 2024 · 3 comments
Labels
tree issues related to the tree (ex: tree widget)

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Oct 7, 2024

Bug Description:

In #14194, two Playwright tests fail on Linux only. These are in theia-explorer-view-tests.ts: 'should delete nested folder "sampleDirectoryCompact/nestedFolder1/nestedFolder2"' and 'should delete compact folder "sampleDirectoryCompact/nestedFolder1"'. The suspicion is that this is actually a timing-dependency that only occurs on Linux. Here's the analysis from the linked PR:

Steps to Reproduce:

I've looked into the failures of the Playwright tests. They only fail on Linux. IMO, this is a bug in the "compressed tree" and is probably unrelated to the change at hand. So, with the resources folder from the playwright test, you can do the following scenario:

delete "nestedFolder2"
Observe: there is no change visible and a console.log in the rendering of the compressed rows is not hit.
Select the row in question
Observe: nestedFolder2 disappears from the row.

The same events seem to be sent on Linux and Windows, so my suspicion is that this is a reordering of async blocks du to the different timings on the respective platforms.

Additional Information

  • Operating System: Linux
  • Theia Version: 1.54.0 master
@tsmaeder tsmaeder added the tree issues related to the tree (ex: tree widget) label Oct 7, 2024
@cdietrich
Copy link

maybe parcel-bundler/watcher#183

@msujew
Copy link
Member

msujew commented Oct 7, 2024

@cdietrich Might be, but unlikely. This issue is 100% reproducible in CI (and likely an issue of our compressed tree implementation). As far as I can tell your parcel watcher issue seems to be more random, right?

@cdietrich
Copy link

yes its quite random

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tree issues related to the tree (ex: tree widget)
Projects
None yet
Development

No branches or pull requests

3 participants