Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui) : Feat/collapse icon indicator #2095

Merged
merged 1 commit into from
Aug 30, 2023
Merged

feat(ui) : Feat/collapse icon indicator #2095

merged 1 commit into from
Aug 30, 2023

Conversation

sameed20
Copy link
Contributor

Issue: #2052
Various tabs in portlets are expanded by default but there is no icon to indicate that these tiles are collapsible.

Change:
I have added the expand/collapse icon to all those tabs which can expand/collapse.

ExpandCollapse

@KoukiHama
Copy link
Member

Hello

CI　returned the error. Please Change the commit history.

＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
Run webiny/[email protected]
ℹ️ Checking if commit messages are following the Conventional Commits specification...
Commit messages:
🚩 (feat):Added collapse and expand icon for all the tabs

Signed-off-by: sameed.ahmad [email protected]
✅ Revert "(feat):Added collapse and expand icon for all the tabs"

This reverts commit 5163cc1745b55e10a75d40a2d20ed5f1a5ca1eb2.
🚩 Revert "Revert "(feat):Added collapse and expand icon for all the tabs""

This reverts commit 60217db8f32f9182488031b0940f7988768e9552.
Error: 🚫 According to the conventional-commits specification, some of the commit messages are not valid.

@sameed20 sameed20 force-pushed the feat/collapse-icon-indicator branch from 32158d8 to 7e656ef Compare August 22, 2023 13:07
@sameed20
Copy link
Contributor Author

Hello

CI　returned the error. Please Change the commit history.

＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝ Run webiny/[email protected] ℹ️ Checking if commit messages are following the Conventional Commits specification... Commit messages: 🚩 (feat):Added collapse and expand icon for all the tabs

Signed-off-by: sameed.ahmad [email protected] ✅ Revert "(feat):Added collapse and expand icon for all the tabs"

This reverts commit 5163cc1745b55e10a75d40a2d20ed5f1a5ca1eb2. 🚩 Revert "Revert "(feat):Added collapse and expand icon for all the tabs""

This reverts commit 60217db8f32f9182488031b0940f7988768e9552. Error: 🚫 According to the conventional-commits specification, some of the commit messages are not valid.

Hi,
I have updated the commit history, you can review.

@sameed20 sameed20 force-pushed the feat/collapse-icon-indicator branch from 7e656ef to 4d7e203 Compare August 22, 2023 14:48
@KoukiHama KoukiHama added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for and removed WIP work in progress do not merge - нет! labels Aug 23, 2023
hoangnt2
hoangnt2 reviewed Aug 23, 2023
View reviewed changes
...0-portlet/src/main/resources/META-INF/resources/html/projects/includes/projects/summary.jspf Outdated
<th colspan="2"><liferay-ui:message key="general.information" /></th>
<th colspan="2">
<div class="d-flex justify-content-between">
<liferay-ui:message key="general" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key="general.information"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hoang,
I have changed the key back to key="general.information"

@KoukiHama KoukiHama changed the title Feat/collapse icon indicator feat(ui) : Feat/collapse icon indicator Aug 23, 2023
@afsahsyeda
Copy link
Contributor

I have carried out a general test. Please note:

  • Replace the existing "click to expand or collapse" text with "Click to Expand" or "Click to Collapse" for each icon respectively.
  • This feature is not implemented for the Packages portlet.

@afsahsyeda afsahsyeda self-requested a review August 23, 2023 05:06
@sameed20 sameed20 force-pushed the feat/collapse-icon-indicator branch from 4d7e203 to 1974005 Compare August 23, 2023 09:00
@sameed20
Copy link
Contributor Author

I have carried out a general test. Please note:

  • Replace the existing "click to expand or collapse" text with "Click to Expand" or "Click to Collapse" for each icon respectively.
  • This feature is not implemented for the Packages portlet.

I have carried out a general test. Please note:

  • Replace the existing "click to expand or collapse" text with "Click to Expand" or "Click to Collapse" for each icon respectively.
  • This feature is not implemented for the Packages portlet.

Hi,
I have made the changes suggested, can you please review.

afsahsyeda
afsahsyeda approved these changes Aug 25, 2023
View reviewed changes
...rtlet/src/main/resources/META-INF/resources/html/components/includes/components/summary.jspf Outdated
});
});

</script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include a new line space

frontend/sw360-portlet/src/main/resources/META-INF/resources/js/modules/expandCollapse.js Outdated
}
}
}
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include new line space

@afsahsyeda afsahsyeda added ready ready to merge and removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Aug 25, 2023
@ag4ums
Copy link
Contributor

ag4ums commented Aug 30, 2023

@hoangnt2, can we merge this PR?

@hoangnt2
Copy link
Contributor

@ag4ums We can merge it now

@ag4ums ag4ums merged commit b079ad5 into eclipse-sw360:main Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afsahsyeda afsahsyeda afsahsyeda approved these changes

@hoangnt2 hoangnt2 hoangnt2 approved these changes

@tienlee tienlee Awaiting requested review from tienlee

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

Assignees
No one assigned
Labels
ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sameed20 @KoukiHama @afsahsyeda @ag4ums @hoangnt2