Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): Update release with attachment info #2092

Conversation

hoangnt2
Copy link
Contributor

Update release with attachment info

How To Test?

{
    "attachments": [
        {
            "attachmentContentId": "{attachment Id in sw360}",
            "sha1": "a56456d2f7ca6d0fa58dfeee3e442cea9130d5ca",
            "attachmentType": "COMPONENT_LICENSE_INFO_XML",
            "createdOn": "2022-08-19",
            "filename": "JUL_to_SLF4J_bridge_1.7.32.spdx.rdf",
            "checkedComment": "",
            "checkStatus": "NOTCHECKED",
            "createdBy": "[email protected]",
            "createdComment": "",
            "createdTeam": "DEPARTMENT"
        }
    ]
}

Expected:

  • If attachmentContentId is existing in sw360: release updated successfully <200>
  • If attachmentContentId is not existing in sw360: release updated fail <404>

@hoangnt2 hoangnt2 force-pushed the release/fix_update-release-with-attachment-info branch from 581e23a to 93546c4 Compare August 17, 2023 08:40
@hoangnt2 hoangnt2 added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for REST New-UI Level for the API and UI level changes for the new-ui labels Aug 17, 2023
@KoukiHama KoukiHama requested a review from ag4ums August 17, 2023 11:09
@nikkuma7
Copy link
Contributor

Test successful.
image
image

@KoukiHama KoukiHama removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Aug 21, 2023
@hoangnt2 hoangnt2 force-pushed the release/fix_update-release-with-attachment-info branch from 93546c4 to 7a785ca Compare August 21, 2023 08:47
@hoangnt2 hoangnt2 force-pushed the release/fix_update-release-with-attachment-info branch from 7a785ca to a330fde Compare August 21, 2023 09:16
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chnages looks good

@ag4ums ag4ums added ready ready to merge and removed needs code review labels Aug 23, 2023
@ag4ums ag4ums merged commit 4eec45d into eclipse-sw360:main Aug 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New-UI Level for the API and UI level changes for the new-ui ready ready to merge REST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants