Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db): clean-up closed moderation requests. #2001

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix(db): clean-up closed moderation requests. #2001

merged 1 commit into from
Oct 4, 2023

Conversation

rudra-superrr
Copy link
Contributor

@rudra-superrr rudra-superrr commented Jun 14, 2023 •
edited
Loading

Issue: closes #2000

@rudra-superrr rudra-superrr added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jun 14, 2023
@ag4ums ag4ums self-assigned this Jun 28, 2023
ag4ums
ag4ums reviewed Jul 26, 2023
View reviewed changes
scripts/migrations/057_closedModReqStats.py Outdated
state = "moderationState"

#for year 2020 (1stjan - 31stdec)
startDate_2020 = 1577847600000
Copy link
Contributor

@ag4ums ag4ums Jul 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take start and end date as input

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, taking date as input

@rudra-superrr rudra-superrr force-pushed the feat/cleanupClosedMR branch 4 times, most recently from 9fbb3c4 to 71dd5cd Compare August 11, 2023 05:32
ag4ums
ag4ums reviewed Aug 11, 2023
View reviewed changes
.github/workflows/build_and_test.yml Outdated
@@ -42,6 +42,7 @@ jobs:

- name: Set environment variables
run: |
echo _JAVA_OPTIONS= '-Djdk.util.zip.disableZip64ExtraFieldValidation=true' >> $GITHUB_ENV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please create an separate PR for this as this is happening due to https://help.liferay.com/hc/en-us/articles/17904500197389-java-util-zip-ZipException-Invalid-CEN-header-invalid-zip64-extra-data-field-size-when-starting-dxp-using-JDK-11-0-20

more info
(https://www.oracle.com/java/technologies/javase/11-0-20-relnotes.html)
java.util.zip.ZipFile has been updated to provide additional validation of ZIP64 extra fields when opening a ZIP file. This validation may be disabled by setting the system property jdk.util.zip.disableZip64ExtraFieldValidation to true.

@rudra-superrr rudra-superrr force-pushed the feat/cleanupClosedMR branch 3 times, most recently from 489675c to 9eaa622 Compare August 16, 2023 06:05
@ag4ums ag4ums removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Sep 11, 2023
ag4ums
ag4ums approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

@ag4ums ag4ums added the ready ready to merge label Sep 11, 2023
@ag4ums
Copy link
Contributor

ag4ums commented Sep 11, 2023

@rudra-superrr , please rebase the brach with current main

@rudra-superrr rudra-superrr force-pushed the feat/cleanupClosedMR branch 2 times, most recently from 0c24e08 to 3215094 Compare September 29, 2023 08:29
@ag4ums ag4ums merged commit fee1059 into eclipse-sw360:main Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ag4ums ag4ums ag4ums approved these changes

Assignees

@ag4ums ag4ums

Labels
ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean-up of moderation requests
2 participants
@rudra-superrr @ag4ums