From aaddfd6beb800c0c54fb51ccae9cf31bc99d9b55 Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Tue, 3 Dec 2024 16:04:39 +0100 Subject: [PATCH] Remove done() call on SubMonitor in Refactoring done() call not necessary here See https://www.eclipse.org/articles/Article-Progress-Monitors/article.html --- .../src/org/eclipse/ltk/core/refactoring/Refactoring.java | 1 - 1 file changed, 1 deletion(-) diff --git a/bundles/org.eclipse.ltk.core.refactoring/src/org/eclipse/ltk/core/refactoring/Refactoring.java b/bundles/org.eclipse.ltk.core.refactoring/src/org/eclipse/ltk/core/refactoring/Refactoring.java index 86a4dac5cc7..2f8f854ad95 100644 --- a/bundles/org.eclipse.ltk.core.refactoring/src/org/eclipse/ltk/core/refactoring/Refactoring.java +++ b/bundles/org.eclipse.ltk.core.refactoring/src/org/eclipse/ltk/core/refactoring/Refactoring.java @@ -162,7 +162,6 @@ public RefactoringStatus checkAllConditions(IProgressMonitor pm) throws CoreExce if (!result.hasFatalError()) { result.merge(checkFinalConditions(subMon.split(refactoringTickProvider.getCheckFinalConditionsTicks()))); } - subMon.done(); return result; }