Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show source on hover & Declaration view broken #2600

Closed
iloveeclipse opened this issue Dec 9, 2024 · 0 comments · Fixed by #2612
Closed

Show source on hover & Declaration view broken #2600

iloveeclipse opened this issue Dec 9, 2024 · 0 comments · Fixed by #2612
Assignees
Labels
bug Something isn't working regression
Milestone

Comments

@iloveeclipse
Copy link
Member

Just discovered that the change #2051 also (additionally to eclipse-jdt/eclipse.jdt.ui#1843) broke source hover functionality in Java editor (Shift + Hover over method to see implementation).

Stack:

java.lang.NullPointerException
	at java.base/java.util.Objects.requireNonNull(Objects.java:233)
	at java.base/java.util.Arrays$ArrayList.<init>(Arrays.java:4238)
	at java.base/java.util.Arrays.asList(Arrays.java:4223)
	at org.eclipse.jface.text.source.SourceViewer.configure(SourceViewer.java:550)
	at org.eclipse.jdt.internal.ui.javaeditor.JavaSourceViewer.configure(JavaSourceViewer.java:224)
	at org.eclipse.jdt.internal.ui.text.java.hover.SourceViewerInformationControl.<init>(SourceViewerInformationControl.java:219)
	at org.eclipse.jdt.internal.ui.text.java.hover.JavaSourceHover$1.<init>(JavaSourceHover.java:888)
	at org.eclipse.jdt.internal.ui.text.java.hover.JavaSourceHover.createControl(JavaSourceHover.java:888)
	at org.eclipse.jdt.internal.ui.text.java.hover.JavaSourceHover.lambda$3(JavaSourceHover.java:883)
	at org.eclipse.jface.text.AbstractInformationControlManager.getInformationControl(AbstractInformationControlManager.java:829)
	at org.eclipse.jface.text.AbstractInformationControlManager.internalShowInformationControl(AbstractInformationControlManager.java:1138)
	at org.eclipse.jface.text.AbstractInformationControlManager.presentInformation(AbstractInformationControlManager.java:1120)
	at org.eclipse.jface.text.AbstractHoverInformationControlManager.presentInformation(AbstractHoverInformationControlManager.java:884)
	at org.eclipse.jface.text.TextViewerHoverManager.doPresentInformation(TextViewerHoverManager.java:237)
	at org.eclipse.jface.text.TextViewerHoverManager.lambda$3(TextViewerHoverManager.java:227)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:5042)

This is a severe regression, @lathapatil : please provide a fix ASAP.
Also please consider to fix review comments from @szarnekow.

@iloveeclipse iloveeclipse added bug Something isn't working regression labels Dec 9, 2024
@iloveeclipse iloveeclipse added this to the 4.35 M1 milestone Dec 9, 2024
lathapatil added a commit to lathapatil/eclipse.platform.ui that referenced this issue Dec 10, 2024
lathapatil added a commit to lathapatil/eclipse.platform.ui that referenced this issue Dec 12, 2024
lathapatil added a commit to lathapatil/eclipse.platform.ui that referenced this issue Dec 12, 2024
@merks merks closed this as completed in b7d5b14 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants