Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search overlay together with split editor: one pane or search overlay steals focus from the other pane #2394

Closed
2 tasks done
Ferdinand-Heinrich opened this issue Oct 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Ferdinand-Heinrich
Copy link

Ferdinand-Heinrich commented Oct 13, 2024

  • I verified I can reproduce this issue against a latest Eclipse IDE installation using the Eclipse Installer by Oomph with CDT (non-embedded) selected

Steps to reproduce

From a fresh installation and clean workspace:

  • create new C++ Hello World sample project

I tried

  • Toggle Split Editor (Vertical) [Toggle Split Editor (Horizontal)]
  • Ctrl+F to spawn search overlay
  • Type something in the search overlay
  • Click into the right [bottom] editor pane

I expected: the right [bottom] editor pane to receive the focus permanently

But got:

  • on Windows 10: focus being in the right [bottom] editor pane for a split second, then jumping back to the left [upper] pane
  • on Qubes OS 4.2 + Fedora 39: focus being in the right [bottom] editor pane for a split second, then jumping into the search overlay instead

Here is some relevant log output

From <workspace>/.metadata/.log

  • nothing logged

Tested under this environment:

  • OS & version:
    • Microsoft Windows 10 Pro, 10.0.19045 Build 19045
    • Qubes OS 4.2 + Fedora 39
  • Eclipse IDE/Platform version (as shown in Help > About): 2024-09 (4.33.0)

Community

  • I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
@Ferdinand-Heinrich Ferdinand-Heinrich added the bug Something isn't working label Oct 13, 2024
@HeikoKlare
Copy link
Contributor

Thank you for reporting this issue!
I can confirm the issue for all kinds of text editors in the 4.33 release, so it also affects, e.g., the Java IDE. I have revalidated the issue with the most recent I-Build (in particular one including the change #2254) and was not able to reproduce the issue there.

Here is a recording with the old and new implementation showing the fixed behavior:
findreplace_focus_split_view

I will thus close this issue as fixed. In case the issue persists even after the mentioned change, please reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants