From 2f68c396556ccdeb766b0d5eb47c074bee526873 Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Tue, 3 Dec 2024 14:45:15 +0100 Subject: [PATCH] Use SubMonintor in TextChange done() call not necessary here and convert can also handle null. See https://www.eclipse.org/articles/Article-Progress-Monitors/article.html --- .../src/org/eclipse/ltk/core/refactoring/TextChange.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/bundles/org.eclipse.ltk.core.refactoring/src/org/eclipse/ltk/core/refactoring/TextChange.java b/bundles/org.eclipse.ltk.core.refactoring/src/org/eclipse/ltk/core/refactoring/TextChange.java index e9f64c62bcb..11c73cf168e 100644 --- a/bundles/org.eclipse.ltk.core.refactoring/src/org/eclipse/ltk/core/refactoring/TextChange.java +++ b/bundles/org.eclipse.ltk.core.refactoring/src/org/eclipse/ltk/core/refactoring/TextChange.java @@ -247,7 +247,6 @@ public Change perform(IProgressMonitor pm) throws CoreException { throw Changes.asCoreException(e); } finally { releaseDocument(document, subMon.newChild(1)); - subMon.done(); } } @@ -311,7 +310,6 @@ public IDocument getCurrentDocument(IProgressMonitor pm) throws CoreException { } finally { releaseDocument(result, subMon.newChild(1)); } - subMon.done(); return result; }