Add support for higher DS versions

[laeubi]

Currently PDE only declares versions up to DS 1.3 in the model but there are already 1.4/1.5 out.

Even though not all features are supported we should allow the user to select a higher version (e.g. to use with Tycho) and to make them aware other versions exits and might can need some improvements/contributions.

[github-actions]

Test Results

     270 files  ±0       270 suites  ±0   43m 19s ⏱️ +39s
  3 327 tests ±0    3 297 ✔️ ±0  30 💤 ±0  0 ❌ ±0 
10 278 runs  ±0  10 188 ✔️ ±0  90 💤 ±0  0 ❌ ±0 

Results for commit 6af5b30. ± Comparison against base commit 20bc28b.

♻️ This comment has been updated with latest results.

[laeubi]

Current status is that I got it working that PDE is able to handel things on the validation level except for this what is probably a bug/something to improve in the TCK itself:

• [ds annotation tck] ServiceSingleton and ServiceBundle using deprecated / invalid combination for DS > 1.2 but do not declare a namespace osgi/osgi#636

so currently there are two validation problems reported:

tck/OSGI-INF/impl-src/org/osgi/impl/bundle/component/annotations/ServiceBundle.java:30 Property 'servicefactory' is ignored when non-default scope is specified. 
tck/OSGI-INF/impl-src/org/osgi/impl/bundle/component/annotations/ServiceSingleton.java:30 Property 'servicefactory' is ignored when non-default scope is specified. 

beside that, PDE-DS has 28 passing and 10 tests left that do not pass not that bad for a first run:

Test run finished after 836 ms
[         5 containers found      ]
[         0 containers skipped    ]
[         5 containers started    ]
[         0 containers aborted    ]
[         5 containers successful ]
[         0 containers failed     ]
[        38 tests found           ]
[         0 tests skipped         ]
[        38 tests started         ]
[         0 tests aborted         ]
[        28 tests successful      ]
[        10 tests failed          ]

[laeubi]

Got it down to 8 testfailures now, things now complained about is mostly properties and properties ordering issues.

[laeubi]

This now passes all the OSGi TCKs!!! 🥇

[HannesWell]

This now passes all the OSGi TCKs!!! 🥇

This is awesome.

Can you please explain how this relates to your other two DS related PRs?

• Add support to validate higher DS versions #926
• Add support for DS 1.4 factory properties #932

Even though not all features are supported we should allow the user to select a higher version (e.g. to use with Tycho) and to make them aware other versions exits and might can need some improvements/contributions.

I assume since the TCK is now fully passed, that all features are implemented? If not we should make the users aware in some way about what is missing.

[laeubi]

Can you please explain how this relates to your other two DS related PRs?

The other ones are mostly splitups from this I'll clear this up once master is open and rebase things.

I assume since the TCK is now fully passed, that all features are implemented?

Sadly the TCK does not cover 1.5 features yet see:

• [ds annotation tck] 1.5 features are missing in the TCK osgi/osgi#642

this does not mean it can't work (maybe it does), but we do not cover this, also maybe someone wants to use a higher feature but not from the annotations... so its quite hard to "tell" the user and I'd better like to invest time in implement the features than explain what is missing ;-)

[laeubi]

N&N added here eclipse-platform/www.eclipse.org-eclipse#98