Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1218 scr1.4 constructor for injection must be public #1463

Closed
wants to merge 5 commits into from

Conversation

EverettHanke
Copy link

This is our codeday solution to open ticket #1218

@iloveeclipse
Copy link
Member

  • Please remove all added / changed project setting files from idea, m2e etc, and leave only files related to the actual fix in th commit.
  • Please squasch all changes to a single commit
  • Please sign ECA.

@EverettHanke
Copy link
Author

Thank you for letting me know. Sorry about that I'm new to this. Just signed the ECA and I'm going to run the changes in one commit as well as not let idea have changes.

@HannesWell
Copy link
Member

No problem :)
Btw. you don't have to close this PR. You can keep it open and just perform a git force-push after you have amended your git commits locally and the undesired files are removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants