Bypass API analysis for classes from a test classpath entry

[merks]

eclipse-platform/eclipse.platform.swt#1298

[github-actions]

Test Results

   291 files  +  2     291 suites  +2   55m 17s ⏱️ - 7m 25s
 3 578 tests ±  0   3 502 ✅ +  1   76 💤  -  1  0 ❌ ±0 
11 031 runs  +166  10 800 ✅ +138  231 💤 +28  0 ❌ ±0 

Results for commit a69e822. ± Comparison against base commit a5391bd.

[laeubi]

Looks good!

[HannesWell]

In a (private) chat with Ed I understood this as a 'last' resort solution but since we got eclipse-platform/eclipse.platform.swt#1305 this is not necessary anymore to fix the underlying issue.
So should we still keep this? If yes, maybe we should move the check to a higher level and let the analyzer just skip test source folders. Then it does not have to be checked again and again when creating problems (which are not always errors).

[merks]

I didn’t merge it. I’m not sure we really need this given swt solved the problem without this.

[laeubi]

I’m not sure we really need this given swt solved the problem without this.

Well SWT not really "solved" this, they installed a workaround (making thing package private) wile this works in this case I still believe test code should not be API checked, if it can happen on a higher level why not.