Remove old 1.x Java compiler versions support from PDE tests #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 291 files ±0 291 suites ±0 58m 20s ⏱️ -7s Results for commit b28de3d. ± Comparison against base commit c32168e. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
@HannesWell : any objections ? |
vogella
reviewed
Jun 18, 2024
ui/org.eclipse.pde.ui.tests/src/org/eclipse/pde/ui/tests/ee/ExportBundleTests.java
Outdated
Show resolved
Hide resolved
vogella
reviewed
Jun 18, 2024
ui/org.eclipse.pde.ui.tests/src/org/eclipse/pde/ui/tests/ee/ExecutionEnvironmentTests.java
Outdated
Show resolved
Hide resolved
vogella
reviewed
Jun 18, 2024
ui/org.eclipse.pde.ui.tests/src/org/eclipse/pde/ui/tests/ee/ExecutionEnvironmentTests.java
Outdated
Show resolved
Hide resolved
vogella
previously requested changes
Jun 18, 2024
No objections, please go ahead. Thanks for being proactive. But please address Lars requests for changes, even if technically not absolutely necessary. |
Basically moves tests that used various old 1.x JDK compiler settings to use 1.8 target (only supported 1.x Java compiler target in the future). See eclipse-jdt/eclipse.jdt.core#2536
HannesWell
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically moves tests that used various old 1.x JDK compiler settings to use 1.8 target (only supported 1.x Java compiler target in the future).
See eclipse-jdt/eclipse.jdt.core#2536