Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceApiTypeRoot: use IFile.readAllBytes() #1296

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Jun 12, 2024

No description provided.

Copy link

github-actions bot commented Jun 12, 2024

Test Results

  206 files   -    85    206 suites   - 85   41m 50s ⏱️ - 18m 36s
3 578 tests ±    0  3 502 ✅ ±    0   76 💤 ± 0  0 ❌ ±0 
7 402 runs   - 3 629  7 248 ✅  - 3 552  154 💤  - 77  0 ❌ ±0 

Results for commit 4d7a0bd. ± Comparison against base commit 3e56c83.

♻️ This comment has been updated with latest results.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these preference changes intended?
Apart from that, this looks good to me. 👍🏽

@jukzi jukzi force-pushed the ResourceApiTypeRoot branch from 8b32eb8 to 4d7a0bd Compare June 13, 2024 10:59
@jukzi
Copy link
Contributor Author

jukzi commented Jun 14, 2024

Are these preference changes intended?

removed.

@jukzi jukzi merged commit c32168e into eclipse-pde:master Jun 14, 2024
16 of 17 checks passed
@jukzi jukzi deleted the ResourceApiTypeRoot branch June 14, 2024 06:42
trancexpress pushed a commit to trancexpress/eclipse.pde that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants