Enable most LocalTargetDefinitionTests in verification builds #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
enable-target-tests
branch
2 times, most recently
from
1f6e2b2 to
5634934
Compare
|
For now I have disabled all cases in LocalTargetDefinitionTests that fail in verification builds and only fixed LocalTargetDefinitionTests.testDeleteCleansCaches, which fails in I-builds #1247 (comment). |
Don't disable LocalTargetDefinitionTests by default in verification builds, only disable those that fail. Some of the disabled tests should probably work even in verification builds and IDE JUnit Plugin tests, but that is left for later. And fix LocalTargetDefinitionTests.testDeleteCleansCaches() test-case that is current failing in I-builds.
HannesWell
force-pushed
the
enable-target-tests
branch
from
5634934 to
98b03a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix LocalTargetDefinitionTests.testDeleteCleansCaches failing in I-builds.
Follow-up on #1247 (comment).