AbstractScriptGenerator.newAntScript: revert close stream #967

[jukzi]

#967

[HannesWell]

Looks good. Lets see what the build says.

And thanks for the little code clean-up.

[github-actions]

Test Results

     273 files  ±0       273 suites  ±0   51m 12s ⏱️ - 2m 57s
  3 443 tests ±0    3 334 ✔️ ±0    47 💤 ±0  22 ❌ ±0    40 🔥 ±0 
10 626 runs  ±0  10 300 ✔️ ±0  141 💤 ±0  66 ❌ ±0  119 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit 43dd886. ± Comparison against base commit bd726ff.

[iloveeclipse]

Interesting, same test fails as before? Does it work locally?

[jukzi]

it fixes SourceTests.testIndividualSourceBundles_2() locally

[iloveeclipse]

it fixes SourceTests.testIndividualSourceBundles_2() locally

So looks like #980 is testing something else (previous build?), not the current code in the PR?

The test fails in this PR are exactly same as in #980

• https://ci.eclipse.org/pde/job/eclipse.pde/job/PR-984/3/testReport/junit/org.eclipse.pde.build.internal.tests/SourceTests/testIndividualSourceBundles_2/
• https://ci.eclipse.org/pde/job/eclipse.pde/job/PR-980/3/testReport/junit/org.eclipse.pde.build.internal.tests/SourceTests/testIndividualSourceBundles_2/

[iloveeclipse]

On the other side, there are not more test fails, so we should simply merge this one and see what the next build would say, if we will have the build tomorrow, see this comment.

[laeubi]

it fixes SourceTests.testIndividualSourceBundles_2() locally

I just wanted to mention that the tests seem to behave completely different in some cases between platforms and between being executed on Jenkins or I-Builds, its a bit messy.