Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding twice --add-opens in product launch parameter is not correct transferred to the launch configuration #1508

Closed
vogella opened this issue Dec 9, 2024 · 2 comments

Comments

@vogella
Copy link
Contributor

vogella commented Dec 9, 2024

Adding the following to the product launch configuration is not taken over correctly to the launch configuration:

--add-opens java.base/java.util=ALL-UNNAMED
--add-opens java.base/java.lang.reflect=ALL-UNNAMED

image

This ends up as the following in the runtime configuration:

-Dorg.eclipse.swt.graphics.Resource.reportNonDisposed=true --add-opens java.base/java.util=ALL-UNNAMED java.base/java.lang.reflect=ALL-UNNAMED

While is should be:

-Dorg.eclipse.swt.graphics.Resource.reportNonDisposed=true --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED
@merks
Copy link
Contributor

merks commented Dec 9, 2024

I expect it's much better to use this variation (without spaces but rather with =) so that nothing thinks there are two duplicate --add-opens arguments where one should be removed to eliminate that duplication:

--add-opens=java.base/java.lang=ALL-UNNAMED

@vogella
Copy link
Contributor Author

vogella commented Dec 9, 2024

Thanks @merks, that works for me.

@vogella vogella closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants