Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve syntax highlighting colors for dark theme in MANIFEST.MF #1503

Open
vogella opened this issue Dec 4, 2024 · 0 comments · May be fixed by #1504
Open

Improve syntax highlighting colors for dark theme in MANIFEST.MF #1503

vogella opened this issue Dec 4, 2024 · 0 comments · May be fixed by #1504

Comments

@vogella
Copy link
Contributor

vogella commented Dec 4, 2024

I noticed in my last Eclipse IDE training session that the contrast in the MANIFEST editor for Keywords is harder to read on not so contrast-way displays. I suggest we change it to the same colors as the class color in the Java editor and remove the bold setting.

It looks very similar but provides a bit more contrast.

Old on the left, new on the right:

image
vogella added a commit to vogellacompany/eclipse.pde that referenced this issue Dec 4, 2024
@vogella
Improve syntax highlighting colors for dark theme in MANIFEST.MF
c2c3e3a 
Changing the color to the same as for classes in the Java editor and
removing the bold setting.

Fixes eclipse-pde#1503
@vogella vogella linked a pull request Dec 4, 2024 that will close this issue
Open
vogella added a commit to vogellacompany/eclipse.pde that referenced this issue Dec 4, 2024
@vogella
Improve syntax highlighting colors for dark theme in MANIFEST.MF
c368ad8 
Changing the color to the same as for classes in the Java editor and
removing the bold setting.

Fixes eclipse-pde#1503
vogella added a commit to vogellacompany/eclipse.pde that referenced this issue Dec 6, 2024
@vogella
Improve syntax highlighting colors for dark theme in MANIFEST.MF
1372671 
Changing the color to the same as for classes in the Java editor and
removing the bold setting.

Fixes eclipse-pde#1503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve syntax highlighting colors for dark theme in MANIFEST.MF vogellacompany/eclipse.pde
1 participant
@vogella