Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target definition file contribution is missing for compare editor #1222

Closed
iloveeclipse opened this issue Apr 8, 2024 · 1 comment · Fixed by #1223
Closed

Target definition file contribution is missing for compare editor #1222

iloveeclipse opened this issue Apr 8, 2024 · 1 comment · Fixed by #1223
Assignees
@iloveeclipse
Labels
bug Something isn't working
Milestone
4.32 M2

Comments

@iloveeclipse
Copy link
Member

As we've seen in the eclipse-platform/eclipse.platform.ui#1798, target definition files don't support syntax coloring in compare editor (yet).

image

This is just missing config in PDE plugin, I will push a fix in a moment.
@iloveeclipse iloveeclipse added the bug Something isn't working label Apr 8, 2024
@iloveeclipse iloveeclipse self-assigned this Apr 8, 2024
iloveeclipse added a commit to iloveeclipse/eclipse.pde.ui that referenced this issue Apr 8, 2024
@iloveeclipse
Register PluginContentMergeViewerCreator for .target content type
a07e8e4 
This enables syntax highlighting for .target files in compare editor.

Fixes eclipse-pde#1222
@iloveeclipse iloveeclipse mentioned this issue Apr 8, 2024
Merged
iloveeclipse added a commit that referenced this issue Apr 8, 2024
@iloveeclipse
Register PluginContentMergeViewerCreator for .target content type
11de65c 
This enables syntax highlighting for .target files in compare editor.

Fixes #1222
@iloveeclipse iloveeclipse added this to the 4.32 M2 milestone Apr 8, 2024
@iloveeclipse iloveeclipse mentioned this issue Apr 8, 2024
Closed
2 tasks
@iloveeclipse
Copy link
Member Author

Result:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveeclipse iloveeclipse

Labels
bug Something isn't working
Projects
None yet
Milestone
4.32 M2
Development

Successfully merging a pull request may close this issue.

Register PluginContentMergeViewerCreator for .target content type iloveeclipse/eclipse.pde.ui
1 participant
@iloveeclipse