Fix UseScanManager.isValidArchive() and UseReportConverter #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In UseScanManager.isValidArchive() the jar/zip-file was closed too early making it impossible to read from it.
|
I imagine/expect they are only used if it can be used via Tycho. |
|
Sometimes these things are made available as an Ant Task and then called by scripts. Beside that Tychon "only" calls the |
|
The code (probably) broken is only called by the preference-page. My remark was meant if API use-scans are used in general and if anybody knows a place where some are produced so that I could use them as sample or if I had to create them by myself. |
|
Let's submit this, although I cannot test this at the moment, it should not make it worse and I expect to improve the situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In UseScanManager.isValidArchive() the jar/zip-file was closed too early making it impossible to read from it.
And in UseReportConverter.getXML() the default look up looked not at the wrong file when computing the filtered-counts.
Since especially the former seems to be broken for some time I wonder if API use-scans are a used feature?
Does anybody know if the is used for the Eclipse SDK or SimRel? With that I could verify if this really is fixed (at the moment this is just an anticipated fix from looking at the code). Maybe @merks or @iloveeclipse?