Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support formating the automatic bundle manifest #804

Open
laeubi opened this issue Oct 19, 2023 · 4 comments · May be fixed by #1029
Open

Support formating the automatic bundle manifest #804

laeubi opened this issue Oct 19, 2023 · 4 comments · May be fixed by #1029
Labels
automatic manifest Bugs releated to automatic manifest generation

Comments

@laeubi
Copy link
Contributor

laeubi commented Oct 19, 2023

Currently the automatic manifest is used in its canonical compressed form what is hard to read.

There should be an option to format it just in case one want to examine it.

FYI As discussed at EclipseCon 2023 @merks @stbischof

@juergen-albert you mentioned a "bnd pretty print function" would be great to link to the class that could perform manifest formating at bnd.
@laeubi laeubi added the automatic manifest Bugs releated to automatic manifest generation label Oct 19, 2023
@stbischof
Copy link

And add in an comment Feature that shortly describes segments of Manifest

@laeubi
Copy link
Contributor Author

laeubi commented Oct 19, 2023

And add in an comment Feature that shortly describes segments of Manifest

The Manifest Specification does not mention any way to have a comment in a manifest file.

@stbischof
Copy link

stbischof commented Oct 19, 2023 •
edited
Loading

https://github.com/bndtools/bnd/blob/master/aQute.libg/src/aQute/lib/manifest/ManifestUtil.java

https://github.com/bndtools/bnd/blob/44cd6d48beac442e7be22f0761231e010b555fa3/biz.aQute.bndlib/src/aQute/bnd/print/JarPrinter.java#L277C2-L277C2

https://github.com/bndtools/bnd/blob/master/biz.aQute.bndlib/src/aQute/bnd/print/JarPrinter.java

@iloveeclipse iloveeclipse changed the title Aupport formating the automatic bundle manifest Support formating the automatic bundle manifest Oct 19, 2023
@laeubi
Copy link
Contributor Author

laeubi commented Oct 19, 2023

ManifestUtil seem not support any specific formating (beside having ordered keys), JarPrinter seems to output a textfile describing the manifest but not a valid Manifest (its a bit hard to guess as there is no javadoc what is the full contract of MultiMap.format).

laeubi added a commit to laeubi/eclipse.pde that referenced this issue Dec 27, 2023
@laeubi
Format the generated manifest
a62f3b1 
Fix eclipse-pde#804
@laeubi laeubi linked a pull request Dec 27, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automatic manifest Bugs releated to automatic manifest generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Format the generated manifest laeubi/eclipse.pde
2 participants
@laeubi @stbischof