Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Validation errors / suggest missing items to add #223

Open
laeubi opened this issue Jul 19, 2022 · 6 comments · May be fixed by #1024
Open

Copy Validation errors / suggest missing items to add #223

laeubi opened this issue Jul 19, 2022 · 6 comments · May be fixed by #1024

Comments

@laeubi
Copy link
Contributor

laeubi commented Jul 19, 2022

Currently, if I validate a product I might get a tree of warnings, but the dialog is hard to use:

  1. it is not resizable so one has to scroll
  2. items are collapsed, so one need to expand them what really is missing
  3. to adjust the product/features/target/... I need to close the dialog (and mostly have forgotten the exact cause...)
  4. I need to find out by hand what might be required

I therefore like to suggest the following:

  • Allow resizing, in general I think the dialog is too small by default given the usual bundle/package names
  • expand all items by default
  • Add a "copy" button that copies a textual representation of the tree into the clipboard so it could be shared and/or pasted in an editor
  • When I select an item show something similar as with the package/bundle selection in the manifest editor that shows what item might fulfill the requirement and allow me to add it directly to the product.
@Dinesh0723
Copy link
Contributor

As part of the enhancement (#305), a new link labeled 'Edit Launch Configuration' has been introduced to the button bar. Adding a new button labeled 'Copy Validation error' to the Validation dialog would resemble the image below:
2023-12-05_20h49_20

Shall I go ahead with PR?

@laeubi
Copy link
Contributor Author

laeubi commented Dec 5, 2023

@Dinesh0723 please go ahead!

@HannesWell
Copy link
Member

As part of the enhancement (#305), a new link labeled 'Edit Launch Configuration' has been introduced to the button bar. Adding a new button labeled 'Copy Validation error' to the Validation dialog would resemble the image below:

Would it be possible to make the elements in the tree copy-able?
This would be in my opinion more intuitive, would save another button and would allow to select/copy only parts and not all.

@Dinesh0723
Copy link
Contributor

Dinesh0723 commented Dec 6, 2023 •
edited
Loading

As part of the enhancement (#305), a new link labeled 'Edit Launch Configuration' has been introduced to the button bar. Adding a new button labeled 'Copy Validation error' to the Validation dialog would resemble the image below:

Would it be possible to make the elements in the tree copy-able? This would be in my opinion more intuitive, would save another button and would allow to select/copy only parts and not all.

There are two issues that I see with providing a context menu for copying,

  1. If there are too many plug-ins for which errors are displayed and if the user wants to copy all of them, it’s difficult to select each one individually and also it is time consuming.
    If all the errors were grouped under a common root, it would have been possible to give the option there (like in Problems View).
  2. It’s hard for the user to know that there is a copy menu option available on context menu.

But yes, another button does make it look more cluttered.

@Dinesh0723
Copy link
Contributor

@laeubi, Shall I go ahead with PR for copy button?

@laeubi
Copy link
Contributor Author

laeubi commented Dec 7, 2023

Looking at the screen I think we probabbly:

  1. make the dialog wider
  2. turn everything into text buttons or make the icon also a link, currently we have buttons, we have a link and an icon-button that's probably to much concepts.

@Dinesh0723 by the way you don't need to ask (me) for changing stuff, actually anyone can create a PR anytime, just in case, but of course it is good to discuss options first.

Dinesh0723 added a commit to Dinesh0723/eclipse.pde that referenced this issue Dec 20, 2023
@Dinesh0723
Copy Validation errors / suggest missing items to add eclipse-pde#223
400a43f 
Introduced a new copy button for copying the validation errors.

Fixes: eclipse-pde#223
@Dinesh0723 Dinesh0723 linked a pull request Dec 20, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Copy Validation errors / suggest missing items to add #223 Dinesh0723/eclipse.pde
3 participants
@laeubi @HannesWell @Dinesh0723