From f489a8e476747c6a4f06bd8c705ac4088b4377d9 Mon Sep 17 00:00:00 2001 From: Jared Galanis Date: Sun, 7 Jul 2024 16:26:39 -0400 Subject: [PATCH] fix: use default ember test scripts in package.json - this fixes an issue with concurrently where both the noserve and serve scripts were being run at the same time causing an error when we switched to pnpm - the default setup in ember is what this PR proposes --- .github/workflows/ci.yml | 2 +- package.json | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a48265d6..774b9dd3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -49,7 +49,7 @@ jobs: - name: Install Dependencies run: pnpm install - name: Run Tests - run: pnpm run test:no-serve + run: pnpm run test acceptance-test: name: "Acceptance test" diff --git a/package.json b/package.json index d1fd65fc..1767d310 100644 --- a/package.json +++ b/package.json @@ -25,8 +25,7 @@ "lint:js:fix": "eslint . --fix", "start": "ember server", "test": "concurrently \"npm:lint\" \"npm:test:*\" --names \"lint,test:\"", - "test:no-serve": "ember test", - "test:serve": "ember test -s", + "test:ember": "ember test", "prepare": "husky install" }, "devDependencies": {