From cd73ef2daf699cdbbdfcc5c197f591e14b898a77 Mon Sep 17 00:00:00 2001
From: Russ Poetker <rpoetke1@jh.edu>
Date: Mon, 11 Dec 2023 09:29:06 -0500
Subject: [PATCH] Fix logging deps issue

---
 pass-deposit-services/deposit-core/pom.xml | 11 +++++------
 pass-deposit-services/deposit-util/pom.xml | 11 +++++------
 pass-deposit-services/pom.xml              |  9 ++++++---
 pass-notification-service/pom.xml          |  3 ---
 4 files changed, 16 insertions(+), 18 deletions(-)

diff --git a/pass-deposit-services/deposit-core/pom.xml b/pass-deposit-services/deposit-core/pom.xml
index 2bb47bd9..24889b9d 100644
--- a/pass-deposit-services/deposit-core/pom.xml
+++ b/pass-deposit-services/deposit-core/pom.xml
@@ -126,6 +126,11 @@
       <artifactId>log4j-over-slf4j</artifactId>
     </dependency>
 
+    <dependency>
+      <groupId>ch.qos.logback</groupId>
+      <artifactId>logback-classic</artifactId>
+    </dependency>
+
     <dependency>
       <groupId>org.eclipse.pass</groupId>
       <artifactId>pass-data-client</artifactId>
@@ -188,12 +193,6 @@
       <scope>runtime</scope>
     </dependency>
 
-    <dependency>
-      <groupId>ch.qos.logback</groupId>
-      <artifactId>logback-classic</artifactId>
-      <scope>runtime</scope>
-    </dependency>
-
     <dependency>
       <groupId>org.springframework.boot</groupId>
       <artifactId>spring-boot-starter-test</artifactId>
diff --git a/pass-deposit-services/deposit-util/pom.xml b/pass-deposit-services/deposit-util/pom.xml
index 47a07abd..de49a6d8 100644
--- a/pass-deposit-services/deposit-util/pom.xml
+++ b/pass-deposit-services/deposit-util/pom.xml
@@ -34,6 +34,11 @@
       <artifactId>slf4j-api</artifactId>
     </dependency>
 
+    <dependency>
+      <groupId>ch.qos.logback</groupId>
+      <artifactId>logback-classic</artifactId>
+    </dependency>
+
     <dependency>
       <groupId>org.springframework.boot</groupId>
       <artifactId>spring-boot-starter</artifactId>
@@ -59,12 +64,6 @@
       <scope>test</scope>
     </dependency>
 
-    <dependency>
-      <groupId>ch.qos.logback</groupId>
-      <artifactId>logback-classic</artifactId>
-      <scope>test</scope>
-    </dependency>
-
     <dependency>
       <groupId>commons-io</groupId>
       <artifactId>commons-io</artifactId>
diff --git a/pass-deposit-services/pom.xml b/pass-deposit-services/pom.xml
index 9c3132d6..8b65e0d0 100644
--- a/pass-deposit-services/pom.xml
+++ b/pass-deposit-services/pom.xml
@@ -64,11 +64,8 @@
   </scm>
 
   <properties>
-    <scp.port>22</scp.port>
-
     <slf4j.version>2.0.6</slf4j.version>
     <logback-classic.version>1.4.12</logback-classic.version>
-    <spring-framework.version>5.1.4.RELEASE</spring-framework.version>
     <commons-net.version>3.9.0</commons-net.version>
     <commons-compress.version>1.21</commons-compress.version>
     <commons-io.version>2.6</commons-io.version>
@@ -105,6 +102,12 @@
         <version>${logback-classic.version}</version>
       </dependency>
 
+      <dependency>
+        <groupId>ch.qos.logback</groupId>
+        <artifactId>logback-core</artifactId>
+        <version>${logback-classic.version}</version>
+      </dependency>
+
       <dependency>
         <groupId>org.slf4j</groupId>
         <artifactId>log4j-over-slf4j</artifactId>
diff --git a/pass-notification-service/pom.xml b/pass-notification-service/pom.xml
index 325e4580..e759e815 100644
--- a/pass-notification-service/pom.xml
+++ b/pass-notification-service/pom.xml
@@ -44,9 +44,6 @@
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
-        <scp.port>22</scp.port>
-        <!-- this overrides the spring-boot-maven-plugin.version property in the parent pom -->
-        <spring-boot-maven-plugin.version>3.0.7</spring-boot-maven-plugin.version>
         <commons-io.version>2.11.0</commons-io.version>
         <junit.jupiter.version>5.9.3</junit.jupiter.version>
         <handlebars.version>4.3.0</handlebars.version>