From 0b69fc360fd1e38be4fdbb26dbabd17e01f5d05b Mon Sep 17 00:00:00 2001
From: John Abrahams <jabrah20@jhu.edu>
Date: Mon, 16 Oct 2023 13:00:41 -0400
Subject: [PATCH] Run tests only once during release

---
 .github/workflows/release.yml | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 763d3c81..cbe06ea5 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -94,6 +94,9 @@ jobs:
       # =============================================================================
       # Start the release
       # =============================================================================
+      - name: Run tests
+        run: mvn -B -U -V -ntp verify
+
       - name: Bump version to release
         run: mvn -B -U -V -ntp versions:update-parent -DparentVersion=$RELEASE
 
@@ -103,10 +106,12 @@ jobs:
           add: pom.xml **/pom.xml
           message: "Update parent version to $RELEASE"
 
+      # Maven Release Plugin is currently configured to hook into the install phase, so tests would normally be run
+      # Since we ran tests at the start of this process, skip tests here to save some time
       - name: Release main POM
         run: |
-          mvn -B -U -V -ntp release:prepare -DreleaseVersion=$RELEASE -Dtag=$RELEASE -DdevelopmentVersion=$NEXT
-          mvn -B -U -V -ntp release:perform -P release
+          mvn -B -U -V -ntp release:prepare -DreleaseVersion=$RELEASE -Dtag=$RELEASE -DdevelopmentVersion=$NEXT -DskipTests -Darguments=-DskipTests
+          mvn -B -U -V -ntp release:perform -P release -DskipTests -Darguments=-DskipTests
         env:
           MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
           MAVEN_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
@@ -123,7 +128,7 @@ jobs:
           push: true
 
       - name: Build and publish new dev version
-        run: mvn -B -U -V -ntp deploy -P release
+        run: mvn -B -U -V -ntp deploy -P release -DskipTests
         env:
           MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
           MAVEN_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}