Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make journal information not editable on Details page #738

Closed
dkriethof opened this issue Sep 21, 2023 · 1 comment · Fixed by eclipse-pass/pass-core#65
Closed

Make journal information not editable on Details page #738

dkriethof opened this issue Sep 21, 2023 · 1 comment · Fixed by eclipse-pass/pass-core#65
Assignees
@markpatton
Milestone
1.1.0 (October)

Comments

@dkriethof
Copy link
Contributor

dkriethof commented Sep 21, 2023 •
edited by markpatton
Loading

Currently on the Details page, the ISSN numbers that are automatically populated by the journal selection are editable. The working group determined there is not workflow that would need these to be editable, and prefer they are fixed fields.

The other journal information should also not be editable.
@dkriethof dkriethof converted this from a draft issue Sep 21, 2023
@dkriethof dkriethof added this to the October launch milestone Sep 21, 2023
@markpatton markpatton changed the title Make ISSNs not editable Make journal information not editable on Details page Oct 2, 2023
@markpatton
Copy link
Contributor

Note that none of this information will modify Journal objects in the system. It is pulled from those objects.

@dkriethof dkriethof moved this from Backlog to Ready for Development in Eclipse PASS Oct 3, 2023
@markpatton markpatton self-assigned this Oct 5, 2023
@markpatton markpatton moved this from Ready for Development to In Progress in Eclipse PASS Oct 5, 2023
@markpatton markpatton linked a pull request Oct 6, 2023 that will close this issue
Make journal-title optional for JScholarship and required for NIHMS eclipse-pass/pass-core#65
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Eclipse PASS Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markpatton markpatton

Labels
None yet
Projects
Eclipse PASS
Archived in project
Milestone
1.1.0 (October)
Development

Successfully merging a pull request may close this issue.

Make journal-title optional for JScholarship and required for NIHMS eclipse-pass/pass-core
2 participants
@markpatton @dkriethof