Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CSRF on /logout #1100

Open
rpoet-jh opened this issue Dec 19, 2024 · 0 comments
Open

Enable CSRF on /logout #1100

rpoet-jh opened this issue Dec 19, 2024 · 0 comments
Labels
Milestone

Comments

@rpoet-jh
Copy link
Contributor

What?

We should see if we can remove CSRF exception for /logout.

Why?

To improve overall security.

How?

Two possibilities:

a) I think if we modified by pass-ui to do a post to /logout instead of a get, we could get rid of the exception.

b) Otherwise if we wanted to get rid of ignoreingRequestMatchers, we would have to modify requireCsrfProtectionMatcher as you suggest. I can't quite remember how different request matchers get joined and what takes precedence. In the worst case you would have to just duplicate the default csrf matcher with our exceptions added in.

Acceptance Criteria

ignoreingRequestMatchers is removed from pass-core SecurityConfiguration and logout works from pass.

Related Issues

https://sonarcloud.io/project/security_hotspots?id=eclipse-pass_pass-core&hotspots=AZPZytbAAdeY80wzvC1F

@github-project-automation github-project-automation bot moved this to Backlog in Eclipse PASS Dec 19, 2024
@rpoet-jh rpoet-jh added this to the 1.14.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

1 participant