Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for deposit to the DSpace REST API #135

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add support for deposit to the DSpace REST API #135

wants to merge 6 commits into from

Conversation

markpatton
Copy link
Contributor

@markpatton markpatton commented Nov 15, 2024 •
edited
Loading

A new deposit option is added which uses the DSpace REST API.

  • Cleaned up DSpace configuration properties
  • Small fix to the duplicate JSONObject warnings when running tests.

DSpace deposit takes three calls and tries to handle resumption after an error in the last two calls.

Operational changes:

  • Can now use repository key DSpace to use the new direct deposit
  • Will need to set additional DSPACE_ variables. See documentation pr below.

TODO:

  • Fix badly formatted error message when missing publication date
  • Fix acceptance tests

Required prs:

@markpatton markpatton marked this pull request as draft November 15, 2024 15:17
@markpatton markpatton linked an issue Nov 15, 2024 that may be closed by this pull request
Add support for deposit using the DSpace REST API eclipse-pass/main#1063
Open
@markpatton markpatton force-pushed the 1063-dspace-rest-deposit branch 2 times, most recently from fec504f to d4a366b Compare November 22, 2024 18:32
@markpatton markpatton force-pushed the 1063-dspace-rest-deposit branch from 6ce178a to d750107 Compare December 16, 2024 14:56
@markpatton markpatton force-pushed the 1063-dspace-rest-deposit branch from 5bf461e to c84a802 Compare January 2, 2025 18:16
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Passed Quality Gate passed

Issues
28 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarQube Cloud

@markpatton markpatton marked this pull request as ready for review January 3, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for deposit using the DSpace REST API
1 participant
@markpatton