Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass-ui release has an extra commit for release and snapshot version updates #1029

Closed
rpoet-jh opened this issue Aug 1, 2024 · 0 comments · Fixed by #1031
Closed

pass-ui release has an extra commit for release and snapshot version updates #1029

rpoet-jh opened this issue Aug 1, 2024 · 0 comments · Fixed by #1031
Assignees
Milestone

Comments

@rpoet-jh
Copy link
Contributor

rpoet-jh commented Aug 1, 2024

With the change to pnpm, the pnpm config set version-git-tag false appears to have stop working. This causes pnpm version --new-version $RELEASE to create a commit, end result is two commits for each version update. We should investigate what the setting is to disable version-git-tag in pnpm.

See the commit history for release 1.9.1 in pass-ui: https://github.com/eclipse-pass/pass-ui/commits/main/

There are four commits for the 1.9.1 release, there should only be two, the ones with the Update version to ... comment.

Not the end of the world, but should be fixed eventually.

@rpoet-jh rpoet-jh converted this from a draft issue Aug 1, 2024
@rpoet-jh rpoet-jh added this to the 1.10.0 milestone Aug 1, 2024
@rpoet-jh rpoet-jh self-assigned this Aug 1, 2024
@rpoet-jh rpoet-jh moved this from Ready for Development to In Progress in Eclipse PASS Aug 1, 2024
@rpoet-jh rpoet-jh linked a pull request Aug 2, 2024 that will close this issue
@rpoet-jh rpoet-jh moved this from In Progress to Peer Review/QA in Eclipse PASS Aug 2, 2024
@github-project-automation github-project-automation bot moved this from Peer Review/QA to Done in Eclipse PASS Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant