Change offset check to 0x7 #20323
Open
Change offset check to 0x7 #20323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhall2
force-pushed
the
atomiclongoffset
branch
2 times, most recently
from
59b0ff4
to
8d91013
Compare
|
@matthewhall2 as this one is fixing/ closing that issue, please use appropriate commit message. See https://github.com/eclipse-openj9/openj9/blob/master/CONTRIBUTING.md#example-commits |
r30shah
requested changes
Oct 17, 2024
matthewhall2
force-pushed
the
atomiclongoffset
branch
2 times, most recently
from
7aa7c9c
to
a56a16a
Compare
done |
matthewhall2
force-pushed
the
atomiclongoffset
branch
2 times, most recently
from
c5bab58
to
13216d5
Compare
|
Please follow up on #20323 (comment), as your change is closing the issue you mentioned, please have description with |
- the "value" field in AtomicLong is of type "long", so it should be aligned to 8-byte boundaries to be used in the atomics intrinsics. Changed offset verification to check for a multiple of 8 instead of a multiple of 4. Closes: eclipse-openj9#20235 Signed-off-by: Matthew Hall <[email protected]>
matthewhall2
force-pushed
the
atomiclongoffset
branch
from
13216d5
to
d084dbf
Compare
r30shah
requested changes
Oct 18, 2024
There was a problem hiding this comment.
I would use following commit title and the body.
Fix fieldAlignment check for AtomicLong on Z
"value" field in AtomicLong is of type "long" and should be
aligned to 8-byte boundary.
Check field alignment for AtomicLong was incorrectly checking if the
offset of the field is aligned to 4 byte boundary instead of 8.
This commit fixes that.
Closes: https://github.com/eclipse-openj9/openj9/issues/20235
Please also update PR title and description, also if you are using the above commit message, please ensure the body width to 72.
Tag me once you make above changes, I will launch sanity changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offset verification for inlineAtomicLong was being verified to be a multiple of 4, however from testing, a multiple of 8 is needed: for compressed refs, the header size is 4 and the offset of the field is 4. For non-compressed refs, the header size is 8 and the field offset is 8.
addresses #20235