Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#297] fix Dark Theme Color #298

Merged

Conversation

BeckerFrank
Copy link
Contributor

No description provided.

@BeckerFrank BeckerFrank changed the title [297] fix Dark Theme Color [#297] fix Dark Theme Color Oct 15, 2023
@BeckerFrank
Copy link
Contributor Author

The issue #297 is an old Bugzilla Bug with a NumberFormatException in Mylyn GradientTooltip

// because of Bug 566549 - Avoid hard code dark colors in the dark theme and find
// (https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c6ce5643aa4a95e49f5d4029bbe5502312ce8160)
// we need do change our code to work with the new values
if (cssValue.equals("#org-eclipse-ui-workbench-DARK_BACKGROUND")) { //$NON-NLS-1$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uggh! :)

@gnl42 gnl42 mentioned this pull request Oct 15, 2023
@BeckerFrank BeckerFrank merged commit f808790 into main Oct 15, 2023
@BeckerFrank BeckerFrank deleted the 297_NumberFormatException_in_Mylyn_GradientTooltip branch October 15, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants