Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+click no longer opens the pom on maven dependencies. #1607

Open
cnoel35 opened this issue Nov 16, 2023 · 6 comments
Open

Ctrl+click no longer opens the pom on maven dependencies. #1607

cnoel35 opened this issue Nov 16, 2023 · 6 comments

Comments

@cnoel35
Copy link

cnoel35 commented Nov 16, 2023

On Eclipse 2023-09, a Ctrl+Click on a pom dependency no longer opens the dependency pom but a file without extension present in the .m2\.lemminx-maven\ folder (what is that lemminx folder ??).
On the same project with eclipse 2022-06 (without this lemminx folder) it works perfectly and opens the corresponding pom.


System information
M2E - POM Editor using LemMinX language server (includes Incubating components)
2.0.5.20230815-1219

Eclipse IDE for Enterprise Java and Web Developers (includes Incubating components)
Version: 2023-09 (4.29.0)
Build id: 20230907-1323

Eclipse Adoptium
jdk-17.0.6.10-hotspot

Windows 10 Version 22H2
build 19045.3570

@cnoel35
Copy link
Author

cnoel35 commented Nov 20, 2023

Nobody has the same behavior ? I'll add a screenshot if it's not clear.
eclipse

@HannesWell
Copy link
Contributor

Nobody has the same behavior ? I'll add a screenshot if it's not clear.

I tried it and I cannot reproduce the described behavior.
@mickaelistria or @vrubezhny do you know anything about this?
In general all Editor functionality is provided through lemminx-maven and its dependencies as described in https://github.com/eclipse-m2e/m2e-core#readme.

@vrubezhny
Copy link
Contributor

Lemminx-maven has changed the path to store the dependencies resolved during the build in order to not pollute the main maven repository with the temp artifact folders which are created on "as-you-type" builds. Building a maven artifacts while editing a pom.xml results in creation of folders/files like:

image

.. which pollutes the repository with the unwanted data and may lead to different problems with maven builds.

So now, everything resolved/installed by maven goes to the maven repository (which is now used as read-only for lemminx-maven), while everything build during the editing goes to that ~/.m2/lemminx-maven folder which is actually a repository, of the same structure as ~/.m2/repository (or whatever configured by the user), but contains all temporary and non-finished data.

And it's expected if some artifact pom file is opened from that lemminx-maven folder by a Ctrl-click.

@cnoel35 if you believe that the file opened by Ctrl-click is wrong or incorrect, please open an issue at https://github.com/eclipse/lemminx-maven/issues and try providing a minimal project that allows to reproduce the issue or describe the steps to be taken to reproduce the issue and clear description of the failure.

@cnoel35
Copy link
Author

cnoel35 commented Nov 22, 2023

Ok, thanks for your responses, I will open an issue in lemminx-maven github.

@cnoel35
Copy link
Author

cnoel35 commented Dec 8, 2023

Here the issue I opened into lemminx-maven : eclipse/lemminx-maven#531
but after testing with several versions of Eclipse, I realized that I also had the problem with Eclipse 2022-09 which does not have a lemminx folder :
"Eclipse opens the itextpdf-5.5.13.3 file (without extension) into .m2\tech\repository\com\itextpdf\itextpdf\5.5.13.3 even though the right file (with pom extension) itextpdf-5.5.13.3.pom exists in the same folder"
The problem therefore does not seem to be linked to lemminx but to the version of eclipse and/or m2e

@githubmiyagi
Copy link

Still a problem in 2023-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants