-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty maven console in 2023-06 #1481
Comments
ping? |
Can you also list the versions of the And check (e.g. in the Host OSGi console) if the Probably either the EPP packages should include the corresponding auto-start configuration or we should add corresponding p2-instructions to auto-start those bundles required by m2e, i.e. logback. |
According to the OSGI console, logback seems to be resolved only and spifly does not even seem to be installed.
|
Hm, even if I manually start the logback bundles, the |
OK, sorry I forgot that the 23-06 release contained logback 1.2.X, which works with slf4j-1.7 (which is why you see 1.7 in your installed plugin list). But the platform the already was shipped with slf4j-2 and therefore probably most bundles, especially the m2e.maven.bundle is wired to the later version.
This is actually not possible, because slf4j.api version 2 cannot resolve without it.
Good question, IIRC one cannot activate/start a fragment, you can only start/activate the host bundle. E.g. a Fragment also cannot have a BundleActivator. But to be sure one should look that up in the OSGi spec: |
I have upgraded to the latest 2.4.0 SNAPSHOT. Using the I can manually start the logback modules and they get activated:
... but the m2e logback fragment remains in the resolved state:
... also, I still do not get any log output in the Maven console. @HannesWell Do you have any other ideas? |
This is really strange, because actually the logback bundle cannot be installed by p2 respectivly cannot be resolved at runtime by OSGi, so it really has to be present. Or you have another OSGI Service Loader Mediator Specification implementation available in your product, but I'm not aware of one besides spifly. Could you check the m2e example product we provide at: There the Maven console should work. If that's right we should check what's missing that the EPPs are in the same working state. Btw. if it helps you, the Product's definition is: |
Indeed.... it seems that
|
Uff. Great investigation and good catch. Looks like wst added these capabilities with https://git.eclipse.org/c/servertools/webtools.servertools.git/commit/plugins/org.eclipse.wst.server.preview/META-INF/MANIFEST.MF?id=92f9fafbca732e088c82a9aa69e3a5f5491591ec. |
@HannesWell Hm... sure... any idea how I can find their issue tracker?
...? |
Not sure if this is the right place ... but here's a bug report: https://bugs.eclipse.org/bugs/show_bug.cgi?id=582259 |
Yes, looks like they are still at Bugzilla, so that seems to be the right place. Lets see what they say. 👍🏽 |
I have checked out the WST code and try to do a local build without the registrar capability... however, when I rebuild, the qualifier of the created artifacts is not updated, e.g. the version of The build uses tycho and tycho seems to auto-generate this version into the repository metadata during the build... I don't find the string |
Usually you need to disable baseline-replace or increase the micro version for your changes to be reflected. |
@laeubi I only find strings such as |
The 100 is the micro version: https://docs.osgi.org/javadoc/r4v43/core/org/osgi/framework/Version.html |
@laeubi Thanks For posterity:
I still don't understand where Tycho got the timestamp for the |
@laeubi Actually, when I increase the micro version, I do get a new version indeed, but the qualifier (timestamp) remains the same... E.g. now I have |
Worse... when I try to install the locally built "Preview Server Support" plugin, the update dialog tells me I need to uninstall the entire WST Server Adapters feature ... even though I built the repo from the top down (i.e. I didn't only build the "Preview Server Support" module, but everything)... 😞
|
Ok, I have uninstalled the WST Server Adapters feature and reinstalled it, this time it installed the locally modified Preview Server Support plugin. Now, the registrar is properly supplied by Aries:
|
I can see that logback is active:
However, still not logging output in the Maven Console View. ... ok Aries was not started automatically... so I started it:
Still no output in the Maven console... Any other ideas? Note that logback didn't seem to register with aries... |
Btw. no luck running the M2E product either. No matter whether I extract it using macOS Finder or using |
Usually you get a printout that tells that a certain service provider was registered with aries. Btw. I prepare the necessary changes for the Eclipse SDK product to active aries initially: The EPP products hopefully adapt this soon, so that only logback needs to be actived too. @reckart I think it would probably help to speed up fixing the wst issue, if you provide a Gerrit Change with your changes. Feel free to add me to it.
Unfortunately I'm not very familiar with mac and don't have access to one and can therefore not help you much with this. |
Thinking about it again, I suspect it could be connected to apache/aries#233. If that's the case, I think we need to add |
and add 'jakarta.servlet-api' as requirement to ensure its present until Aries can handle its absense for logback: apache/aries#233 Fixes eclipse-m2e#1481
and add 'jakarta.servlet-api' as requirement to ensure its present until Aries can handle its absense for logback: apache/aries#233 Fixes eclipse-m2e#1481
and add 'jakarta.servlet-api' as requirement to ensure its present until Aries can handle its absense for logback: apache/aries#233 Fixes eclipse-m2e#1481
I'm currently testing #1512 and the logback configuration from m2e looks good so far.
I just created a PR to remove that from rap: eclipse-rap/org.eclipse.rap.tools#49 I also checked the latest SimRel Repo milestone and besides the two bundles in RAP and WST nobody else seems to fake these capabilities. |
and add 'jakarta.servlet-api' as requirement to ensure its present until Aries can handle its absense for logback: apache/aries#233 Fixes #1481
Everthing that m2e can do is so far done. I plan to provide the necessary changes to EPP to auto-start aries in the provided Eclipse Packages this weekend. And then we can only wait for RAP and WST to contribute their fixed bundles to the Eclipse Simultaneous Release. |
FYI I have also created the PR in the Eclipse Packaging Project EPP (the one that provides the downloadable Eclipse Packages) to configure aries.spifly properly: eclipse-packaging/packages#43 So everything should be set up. We just have to wait until all parts are assembled. |
I just verified that the Maven-Console is again working with an out-of-the-box an 2023-09 M3 |
Yay!!! Upgraded to 2023-09 and the console is working again. Thanks for the fix! |
Great. Thanks for reporting back. :) |
I have upgraded my m2e installation to 2.3.0 in Eclipse 2023-06 and now no longer get output in the Maven Console View. Relevant plugins seem to be installed.
Is this (again) a known issue?
Is there a known fix or workaround?
Older similar issue: #182
The text was updated successfully, but these errors were encountered: