"maven-enforcer-plugin (goal "enforce") is ignored by m2e" warning after upgrade to maven-enforcer-plugin 3.2.1

[vtintillier]

Hello,

I am not sure if the behavior I see is intended or not.

maven-enforcer-plugin removed their META-INF/m2e/lifecycle-mapping-metadata.xml file in their last 3.2.1 release (apache/maven-enforcer#192). As a result, we see this warning in all our poms:

maven-enforcer-plugin (goal "enforce") is ignored by m2e

It seems this messages originate from this code:

m2e-core/org.eclipse.m2e.core/lifecycle-mapping-metadata.xml

Lines 120 to 134 in e379405

	<pluginExecution>
	<pluginExecutionFilter>
	<groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-enforcer-plugin</artifactId>
	<goals>
	<goal>enforce</goal>
	</goals>
	<versionRange>[1.0-alpha-1,)</versionRange>
	</pluginExecutionFilter>
	<action>
	<ignore>
	<message>maven-enforcer-plugin (goal "enforce") is ignored by m2e.</message>
	</ignore>
	</action>
	</pluginExecution>

So my question is: is this expected that goals ignored in m2e-core own lifecycle-mapping-metadata.xml appear as warnings in the editor, whereas goals ignored in maven plugins own lifecycle-mapping-metadata.xml do not?
Also is there a way to disable those warnings?

Thanks
Vivien

[kwin]

I think the message part inside the ignore lets m2e emit that warning. I don't think this warning is useful but rather confusing therefore I propose to remove all message lines from

m2e-core/org.eclipse.m2e.core/lifecycle-mapping-metadata.xml

Line 131 in e379405

<message>maven-enforcer-plugin (goal "enforce") is ignored by m2e.</message>

. @laeubi WDYT?

[laeubi]

I think the only useful thing would be if m2e suggest something actionable, e.g.

m2 does not support maven-enforcer-plugin (goal "enforce") with version X please upgrade to at least version Y to get full support

But if we choose that ignore is ok and the user can't do anything anyways , the message can be removed.

[kwin]

Alternatively we can lower the severity for those messages just to make the user aware of the status quo, but this isn't anything to fix (i.e. ERROR or WARN is just wrong).

[laeubi]

Yep, but the question is, as a user, what should I do with such a message? e.g. are there cases where I do NOT want to ignore that goal?

[vtintillier]

@kwin @laeubi So is it OK if I create an issue from this discussion, and create a PR where I remove the messages from the <ignore> elements?

[laeubi]

Sure.