Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for SnippetTextEdit #810

Open
mickaelistria opened this issue Feb 16, 2024 · 4 comments · May be fixed by #847
Open

Support for SnippetTextEdit #810

mickaelistria opened this issue Feb 16, 2024 · 4 comments · May be fixed by #847
Labels
enhancement help_wanted

Comments

@mickaelistria
Copy link
Contributor

mickaelistria commented Feb 16, 2024 •
edited
Loading

See microsoft/language-server-protocol#1892 & microsoft/language-server-protocol#724
SnippetTextEdit is one of the most important features of LSP for a long time as it enables much more convenient workflows for refactorings.
@nixel2007
Copy link
Contributor

If I understand it correctly, it is not even in master branch of specification yet.

@mickaelistria
Copy link
Contributor Author

If I understand it correctly, it is not even in master branch of specification yet.

Yes, it got merged in master yesterday with microsoft/language-server-protocol#1892 and will be part of upcoming LSP 3.18 release.

@rgrunber rgrunber mentioned this issue Jun 27, 2024
Closed
@rgrunber
Copy link

If no one is working on this, maybe @hopehadfield might be interested in contributing back the custom classes in JDT-LS she has written/is writing to fill the lack of support in LSP4J.

@cdietrich
Copy link
Contributor

Is there an eta for 3.18

@hopehadfield hopehadfield linked a pull request Aug 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help_wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for SnippetTextEdit hopehadfield/lsp4j
5 participants
@cdietrich @mickaelistria @jonahgraham @nixel2007 @rgrunber