Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quickfix "remove 'restriction' token is not able to handle several cases in one file in one run #1668

Closed
carstenartur opened this issue Sep 21, 2024 · 1 comment
Closed

quickfix "remove 'restriction' token is not able to handle several cases in one file in one run #1668

carstenartur opened this issue Sep 21, 2024 · 1 comment
Assignees
@jjohnstn
Labels
enhancement New feature or request

Comments

@carstenartur
Copy link
Contributor

carstenartur commented Sep 21, 2024 •
edited
Loading

Trying to move the tests from a separate folder to the usually used jdt.tests project in
#1631
I have to remove a lot of suppressions for warnings (that they are needed might be another issue in jdt).

image

You have to do that one after another because there is no option to remove all equal suppressions at once.
Is that intended?
@jjohnstn
Copy link
Contributor

Intended isn't the correct word. There are fixes that do that, this one isn't set up to do that. That said, I will look into making it a multifix.

@jjohnstn jjohnstn self-assigned this Sep 24, 2024
@jjohnstn jjohnstn added the enhancement New feature or request label Sep 24, 2024
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Sep 25, 2024
@jjohnstn
Allow multiple removal of unused suppress warnings tokens
a30b50d 
- add new UnusedSuppressWarningsCleanUp and
  UnusedSuppressWarningsFixCore to create FixCorrectionProposals to
  remove a single unused warning token, remove all unused warning
  tokens with a particular name, and remove all unused warning
  tokens
- modify SuppressWarningsBaseSubProcessor to create up to 3 of the
  above fix correction proposals (assuming there are more than 1
  problem flagged for a particular warning token and more than 1
  warning token flagged in problems
- add new test to CleanUpTest1d8
- fixes eclipse-jdt#1668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjohnstn jjohnstn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjohnstn @carstenartur