-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23] Folding a markdown region hides the first line of subsequent Java code #1615
Comments
@jarthana have you seen this? |
Thanks, will take a look. |
Actually, I don't see fold/unfold option at all for markdown comments. Sigh! Let me see what's going on. |
This turned out to be the result of making the feature standard feature. Without that patch, the markdown folds/unfolds well. Anyway, I am unable to see the problem. @stephan-herrmann Can you please check now? |
Wow, for preview features, Sharing a scanner seems to be incompatible with version-dependent scanning :-( |
When setting the workspace default compliance to 23 I can still see the same problem as before. @jarthana Here's the difference: I normally use unix line-ends. When I change this to windows line-ends, folding is correct. Conversely, you should be able to see the bug when switching to unix line-ends. Does this help to find some off-by-one bug? |
Yeah, that is written based on the assumption that preview can only be enabled when the compliance is the highest. That works within the compiler but as it turns out, not all clients follow that rule. |
Reproduced. Thanks for the tip! |
Given
when you fold the markdown comment in the editor, it looks like this:
@jarthana looks like your latest change in #1549 only moved the problem :)
The text was updated successfully, but these errors were encountered: