What is the purpose of ChunkSender::tryGetPreviousChunk
#2226
Unanswered
gpalmer-latai
asked this question in
Q&A
Replies: 2 comments
-
|
@gpalmer-latai I no longer remember. But if it's not used outside unit tests, I would say YAGNI. |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
@gpalmer-latai AFAIR this was once an optimization to reclaim the last sent chunk if it already was released by all subscriber. I think it was just forgotten to be removed from the lower layers. Do you want to take care of the removal or shall I add it to my list? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This function seems to be unused outside of unit tests. It appears to return a pointer to a chunk, which is NOT backed by reference counting and could be overwritten at any moment. Was this intended to be used at an earlier time for some poor man's publisher history?
Beta Was this translation helpful? Give feedback.
All reactions