Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chectl: It seems no check OIDC provider configured using getEnsureOIDCProviderInstalledTask Task #23047

Closed
ynqa opened this issue Jul 19, 2024 · 3 comments
Labels
area/chectl Issues related to chectl, the CLI of Che good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! kind/bug Outline of a bug - must adhere to the bug report template. severity/P3 Lower priority than a P2. Optional work that might get done, or not. See also help wanted issues.

Comments

@ynqa
Copy link

ynqa commented Jul 19, 2024

Describe the bug

There is a task called getEnsureOIDCProviderInstalledTask to check whether OIDC provider was configured

However, this task is not called from anywhere, especially not from deploy.ts. So it seems to be skipped on server:deploy running regardless of whether --skip-oidc-provider-check is specified or not.

Che version

7.88@latest

Steps to reproduce

Simply run the following server:deploy command without --skip-oidc-provider-check flag

chectl server:deploy \
    --platform=k8s \
    --skip-cert-manager \
    --domain=${DOMAIN} \
    --che-operator-cr-patch-yaml=${PATCH_FILE_PATH}

If the task is enabled, the title of Check if OIDC Provider installed will be displayed

But not like:
(Note that this is the state in progress)

✔ Verify Kubernetes API...[1.28+]
  ✔ Kubernetes preflight checklist
    ✔ Verify if kubectl is installed...[OK]
    ✔ Verify domain is set...[OK]
  ✔ Create Namespace eclipse-che...[Exists]
  ↓ Install Cert Manager v1.8.2 [skipped]
  ✔ Start following Eclipse Che installation logs...[OK]
  ❯ Deploy Eclipse Che operator
    ❯ Install Dev Workspace operator
      ⠙ Create Namespace devworkspace-controller
        Create Dev Workspace operator resources
        Wait for Dev Workspace operator ready
      Create ServiceAccount che-operator
      Create RBAC
      Create Certificate che-operator-serving-cert
      Create Issuer che-operator-selfsigned-issuer
      Create Service che-operator-service
      Create CRD checlusters.org.eclipse.che
      Waiting
      Create Deployment che-operator
      Eclipse Che Operator pod bootstrap
      Create ValidatingWebhookConfiguration org.eclipse.che
      Create MutatingWebhookConfiguration org.eclipse.che
      Create CheCluster Custom Resource

Expected behavior

During the certain per-installation phase, the title of Check if OIDC Provider installed is displayed, and it is checked whether issuer url and client id are defined as arguments of kube-apiserver.

Runtime

Kubernetes (vanilla)

Screenshots

Probably not necessary.

Installation method

chectl/latest

Environment

macOS

Eclipse Che Logs

No response

Additional context

No response

@ynqa ynqa added the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 19, 2024
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 19, 2024
@ibuziuk ibuziuk added area/chectl Issues related to chectl, the CLI of Che severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 22, 2024
@ibuziuk
Copy link
Member

ibuziuk commented Jul 22, 2024

@ynqa would you be interested in contributing a fix?

@ibuziuk ibuziuk added good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! severity/P3 Lower priority than a P2. Optional work that might get done, or not. See also help wanted issues. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Jul 22, 2024
@ynqa
Copy link
Author

ynqa commented Jul 24, 2024

@ibuziuk I just submitted the pull request che-incubator/chectl#2902. Please confirm it :)

@ynqa
Copy link
Author

ynqa commented Jul 29, 2024

che-incubator/chectl#2902 was merged.

@ynqa ynqa closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! kind/bug Outline of a bug - must adhere to the bug report template. severity/P3 Lower priority than a P2. Optional work that might get done, or not. See also help wanted issues.
Projects
None yet
Development

No branches or pull requests

3 participants