Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing e2e tests does not create screenshot #22529

Closed
dkwon17 opened this issue Sep 19, 2023 · 1 comment · Fixed by #22536
Closed

Failing e2e tests does not create screenshot #22529

dkwon17 opened this issue Sep 19, 2023 · 1 comment · Fixed by #22536
Assignees
Labels
area/qe kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.

Comments

@dkwon17
Copy link
Contributor

dkwon17 commented Sep 19, 2023

Describe the bug

When running export USERSTORY=SmokeTest && npm run test to run the smoke tests, if there is a test failure, there are no screenshot, pagesource, or browserlog files in the reports folder.

Here is the terminal output: log

Che version

7.74@latest

Steps to reproduce

  1. Checkout this branch (this contains a smoke test that will always fail) https://github.com/dkwon17/che/tree/failSmoke
  2. Set env variables:
export TS_SELENIUM_BASE_URL=<baseurl>
export TS_SELENIUM_OCP_USERNAME=<username>
export TS_SELENIUM_OCP_PASSWORD=<password>
  1. Run cd tests/e2e`
  2. Run export USERSTORY=SmokeTest && npm run test
  3. After smoke test fails, check the tests/e2e/reports folder to verify that there is no screenshot, pagesource file or browser log file

Expected behavior

I expected a screenshot, pagesource file and browser log file

Runtime

OpenShift

Screenshots

No response

Installation method

other (please specify in additional context)

Environment

macOS

Eclipse Che Logs

No response

Additional context

I noticed the screenshot is created (but no pagesource, or browserlog file) if the driverHelper is retrieved with e2eContainer.get like so: https://github.com/eclipse/che/blob/41d1364f679779f61e3d17f248bcb5de260c22a4/tests/e2e/utils/CheReporter.ts#L28, instead of constructor injection

@dkwon17 dkwon17 added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 19, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 19, 2023
@nallikaea nallikaea self-assigned this Sep 20, 2023
@nallikaea nallikaea linked a pull request Sep 20, 2023 that will close this issue
9 tasks
@nallikaea
Copy link
Contributor

Thank you for creating the issue, I double checked and provided fix:

#22536

@dmytro-ndp dmytro-ndp added severity/P1 Has a major impact to usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs. area/qe and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qe kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants