Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Well this is embarrassing... Fix publisher #44

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Well this is embarrassing... Fix publisher #44

merged 2 commits into from
Oct 18, 2023

Conversation

thegecko
Copy link
Contributor

What it does

The publisher was set to a previous incorrect one, now using the correct eclipse-cdt

Review checklist

Reminder for reviewers

colin-grant-work
colin-grant-work approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the politics of the publisher namespaces, but I have no objection to this change.

@thegecko thegecko merged commit bdc77f0 into main Oct 18, 2023
4 checks passed
@thegecko thegecko deleted the fix-publisher branch October 18, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thegecko @colin-grant-work