Add main XY (TSP) endpoints support to client with tests #28
Conversation
There was a problem hiding this comment.
UX issue, we need a way to get the times of the trace first.
List-experiment works, but it is not obvious to a new user
Also the fetch-xy unit test fails on my machine. Is this known, should it work?
FAILED test_tsp.py::TestTspClient::test_fetch_xy - AttributeError: 'NoneType' object has no attribute 'status'
Asside from that I approve this, I'll put a trusting +2 assuming the questions are answered. Even if these comments are accidentally not read, no harm, the issues are minor compared to the improvements this patch brings in.
These follow the current TSP spec.
I added an assert in the latest patch, but this works locally for me.
Thanks! :) |
|
My latest force-push (diff linked from right above) only did this:
|
Do not rename the existing --get-tree cli script option, to preserve backward compatibility with potential usage of it. Only use an 'xy' infix in the name of the hereby added option, discriminating it from that existing one for timegraph. Assume EntryModel's default XY_TREE model_type while initializing the GenericResponse for this case. Update README's own copy of ./tsp-cli-client -h, accordingly. Signed-off-by: Marco Miller <[email protected]>
Add a --get-xy cli script option along with its --items and --times siblings. Update README's copy of script's -h, accordingly. Make that script able to print the resulting XYModel contents as applicable. Add a test, along with REQUESTED_TIME_XY value constants matching its kernel test trace used; this is the trace that is already used across all of those tests. Make that new test wait for its analysis to be done running (so, complete or else), prior to try accessing its XY data. The latter is otherwise not accessible yet. Limit this test scope depth to what the sibling tests currently cover. (Deeper coverage backlogged.) Move related constants as TspClient members so they are reused. Unlike existing TspClient methods, the hereby added one requires parameters, as it cannot infer default values for those in that specific case. Existing default requested_times values in TspClient may require revisiting. Signed-off-by: Marco Miller <[email protected]>
While outputting a corresponding message should this happen. Have that code exit right away in the latter case, instead of not handling this. Use the past tense in that message, as the model may become available after a short while, if retried. Signed-off-by: Marco Miller <[email protected]>
Replace these previously ineffective defaults with none, if none passed. Signed-off-by: Marco Miller <[email protected]>
Signed-off-by: Marco Miller [email protected]