Hide excluded rows #296
Merged
Hide excluded rows #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One dependency is not passing the license check: An IP Ticket has already been register against it, earlier today: Update:
Since this PR did not trigger the failed license check, and the license check failure seems very likely to be a false-positive, I think it can be ignored in the PR here. I think the IP Ticket will be approved soon and the failure will disappear - it if takes a while we can add an exception for this specific dependency to be ignored. |
bhufmann
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Looks good to me. I tested it using eclipse-cdt-cloud/theia-trace-extension#1120 with small and large traces. Thanks!
When rows models are fetched from the data provider, if any requested row is not returned, consider that this row has been excluded by EXCLUDE filtering, and remove its row component. Reposition all remaining rows when rows are excluded. Keep track of excluded rows and of the world range that was used to exclude them. During fullSearch with EXCLUDE filter, add previously excluded rows to the request to determine if they should reappear. When complete update is requested, remove row components that are not visible because they would otherwise not be updated and their states could linger at the wrong position. After a fullSearch update is completed, restart another request in case new rows have become visible due to space left by newly excluded rows. Skip coarse update when EXCLUDED filter is applied. This helps prevent matching states that are only found in finer updates from temporarily disappearing during the coarse update. Adjust the limits when moving vertically considering excluded rows. Signed-off-by: Patrick Tasse <[email protected]>
PatrickTasse
force-pushed
the
hiderows
branch
from
4ec3efb to
f7bc9f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rows models are fetched from the data provider, if any requested row is not returned, consider that this row has been excluded by EXCLUDE filtering, and remove its row component. Reposition all remaining rows when rows are excluded.
Keep track of excluded rows and of the world range that was used to exclude them.
During fullSearch with EXCLUDE filter, add previously excluded rows to the request to determine if they should reappear.
When complete update is requested, remove row components that are not visible because they would otherwise not be updated and their states could linger at the wrong position.
After a fullSearch update is completed, restart another request in case new rows have become visible due to space left by newly excluded rows.
Skip coarse update when EXCLUDED filter is applied. This helps prevent matching states that are only found in finer updates from temporarily disappearing during the coarse update.
Adjust the limits when moving vertically considering excluded rows.