Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to show error message if it fails to retrieve metadata? #158

Open
iAmMrinal0 opened this issue Jul 13, 2015 · 1 comment
Open

Comments

@iAmMrinal0
Copy link

So I have PlexWatch running for quite some time and I have moved my library around many times and this resulted in the media ID's to change which means in some cases it will always try to retrieve details for the ID which has since moved to a new ID, so no metadata.

As you can see in the screenshot, the last item isn't retrieved and shows a failed message. So is that necessary? Or do we take the approach as it is in the master branch(see screenshot), i.e. not show the error at all.

dev branch
screenshot 1
master branch
screenshot 2

@Arcanemagus
Copy link
Collaborator

Personally I follow the approach that this is a client for the plexWatch database:
If it has invalid data in it it should be fixed there, and in the meantime we should simply report that to the user.

The master branch isn't really handling this nicely... it just isn't handling this failure mode at all.

If somebody wants to create a PR to handle that failure in a different manner I'm not opposed to it, but as far as I'm concerned this is working as intended.

Thoughts @ecleese?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants